From mboxrd@z Thu Jan 1 00:00:00 1970 From: jani.nikula@linux.intel.com (Jani Nikula) Date: Fri, 02 Feb 2018 16:37:55 +0200 Subject: clang warning: implicit conversion in intel_ddi.c:1481 In-Reply-To: <20180202131328.GA4456@kroah.com> References: <20180201180240.GA28042@kroah.com> <87372jkcu5.fsf@intel.com> <20180202100613.GA21492@kroah.com> <87h8qzisbt.fsf@intel.com> <20180202131328.GA4456@kroah.com> Message-ID: <871si3ihj0.fsf@intel.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Fri, 02 Feb 2018, Greg KH wrote: > On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: >> >> +Knut, Fengguang >> >> On Fri, 02 Feb 2018, Greg KH wrote: >> > - If clang now builds the kernel "cleanly", yes, I want to take >> > warning fixes in the stable tree. And even better yet, if you >> > keep working to ensure the tree is "clean", that would be >> > wonderful. >> >> So we can run sparse using 'make C=1' and friends, or other static >> analysis tools using 'make CHECK=foo C=1', as long as the passed command >> line params work. There was work by Knut to extend this make checker >> stuff [1]. Since mixing different HOSTCC's in a single workdir seems >> like a bad idea, I wonder how hard it would be to make clang work like >> this: >> >> $ make CHECK=clang C=1 >> >> Or using Knut's wrapper. Feels like that could increase the use of clang >> for static analysis of patches. > > Why not just build with clang itself: > make CC=clang Same as HOSTCC, mixing different CC's in a single build dir seems like a bad idea. Sure, everyone can setup a separate build dir for clang, but IMHO having 'make CHECK=clang C=1' work has least resistance. YMMV. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: clang warning: implicit conversion in intel_ddi.c:1481 Date: Fri, 02 Feb 2018 16:37:55 +0200 Message-ID: <871si3ihj0.fsf@intel.com> References: <20180201180240.GA28042@kroah.com> <87372jkcu5.fsf@intel.com> <20180202100613.GA21492@kroah.com> <87h8qzisbt.fsf@intel.com> <20180202131328.GA4456@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180202131328.GA4456@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Greg KH Cc: sil2review@lists.osadl.org, kernelnewbies@kernelnewbies.org, David Airlie , llvmlinux@lists.linuxfoundation.org, intel-gfx@lists.freedesktop.org, Knut Omang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Ozan Alpay , Lukas Bulwahn List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAwMiBGZWIgMjAxOCwgR3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+ IHdyb3RlOgo+IE9uIEZyaSwgRmViIDAyLCAyMDE4IGF0IDEyOjQ0OjM4UE0gKzAyMDAsIEphbmkg TmlrdWxhIHdyb3RlOgo+PiAKPj4gK0tudXQsIEZlbmdndWFuZwo+PiAKPj4gT24gRnJpLCAwMiBG ZWIgMjAxOCwgR3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+PiA+ IAktIElmIGNsYW5nIG5vdyBidWlsZHMgdGhlIGtlcm5lbCAiY2xlYW5seSIsIHllcywgSSB3YW50 IHRvIHRha2UKPj4gPiAJICB3YXJuaW5nIGZpeGVzIGluIHRoZSBzdGFibGUgdHJlZS4gIEFuZCBl dmVuIGJldHRlciB5ZXQsIGlmIHlvdQo+PiA+IAkgIGtlZXAgd29ya2luZyB0byBlbnN1cmUgdGhl IHRyZWUgaXMgImNsZWFuIiwgdGhhdCB3b3VsZCBiZQo+PiA+IAkgIHdvbmRlcmZ1bC4KPj4gCj4+ IFNvIHdlIGNhbiBydW4gc3BhcnNlIHVzaW5nICdtYWtlIEM9MScgYW5kIGZyaWVuZHMsIG9yIG90 aGVyIHN0YXRpYwo+PiBhbmFseXNpcyB0b29scyB1c2luZyAnbWFrZSBDSEVDSz1mb28gQz0xJywg YXMgbG9uZyBhcyB0aGUgcGFzc2VkIGNvbW1hbmQKPj4gbGluZSBwYXJhbXMgd29yay4gVGhlcmUg d2FzIHdvcmsgYnkgS251dCB0byBleHRlbmQgdGhpcyBtYWtlIGNoZWNrZXIKPj4gc3R1ZmYgWzFd LiBTaW5jZSBtaXhpbmcgZGlmZmVyZW50IEhPU1RDQydzIGluIGEgc2luZ2xlIHdvcmtkaXIgc2Vl bXMKPj4gbGlrZSBhIGJhZCBpZGVhLCBJIHdvbmRlciBob3cgaGFyZCBpdCB3b3VsZCBiZSB0byBt YWtlIGNsYW5nIHdvcmsgbGlrZQo+PiB0aGlzOgo+PiAKPj4gJCBtYWtlIENIRUNLPWNsYW5nIEM9 MQo+PiAKPj4gT3IgdXNpbmcgS251dCdzIHdyYXBwZXIuIEZlZWxzIGxpa2UgdGhhdCBjb3VsZCBp bmNyZWFzZSB0aGUgdXNlIG9mIGNsYW5nCj4+IGZvciBzdGF0aWMgYW5hbHlzaXMgb2YgcGF0Y2hl cy4KPgo+IFdoeSBub3QganVzdCBidWlsZCB3aXRoIGNsYW5nIGl0c2VsZjoKPiAJbWFrZSBDQz1j bGFuZwoKU2FtZSBhcyBIT1NUQ0MsIG1peGluZyBkaWZmZXJlbnQgQ0MncyBpbiBhIHNpbmdsZSBi dWlsZCBkaXIgc2VlbXMgbGlrZSBhCmJhZCBpZGVhLiBTdXJlLCBldmVyeW9uZSBjYW4gc2V0dXAg YSBzZXBhcmF0ZSBidWlsZCBkaXIgZm9yIGNsYW5nLCBidXQKSU1ITyBoYXZpbmcgJ21ha2UgQ0hF Q0s9Y2xhbmcgQz0xJyB3b3JrIGhhcyBsZWFzdCByZXNpc3RhbmNlLiBZTU1WLgoKQlIsCkphbmku CgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225Qa3e8AmqqFyR7ECZgkNrS8fXkE4gU+kt5WmkY6s33dBOTx5vTgffHpPkpKyzW1LG9IGG9 ARC-Seal: i=1; a=rsa-sha256; t=1517582288; cv=none; d=google.com; s=arc-20160816; b=PeoDrd5W9aj22djEGxqNErT366FcDsGHyflnlSwFUbRBK9LNGXTgCSJbasc3vAqxu/ LuA9R6Ys126a9LmjyGvoq4RuRYpJh/tVi1QttJaxHyg33+nnQyxzFrWPshX8v1hi+GZs mZNDGO8BTdfuoBrcsA8gs17gsnWCArKRsg7qq3gsUXV/GHBPNb8gvNKLTOWsxeApeuQ5 BBWsIWIq5SVjSDzKqao3RJK+sTLR1myJXp9XcoRXcEfKvgPYjOW42d/U6fL0FD4foI3y kKYGRjgLuGC7/ZFIquGxN4DSoqkX/YeWkYfXVigPxpI0DJGorzqWk2V3dcpCS3Lykqn/ ExlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:references:organization:in-reply-to :subject:cc:to:from:arc-authentication-results; bh=pI4t1esEJvadRmmJgQilGSzQx28y+78e4TLv8ZmI2YQ=; b=DCgC0h2gxbNiX74J0+anVwwTHyMQm7mbY70cFw7uw87Mj6ymHJUp3w6S8eYKUyOraB IBrGhxGaXMz4FA85oQpFRzzluWzpB/hfLvFJt57HjyzqHufOTWvgQha1u1m8ElSJzOot 2i6GQ0dPv3TvHWwIfO6lvFCTXoYgCsvEbGE37qIg0ufEGhwfCjNRfRbGsKk4syNaCMcS O/ZG7RD9a+qRF6ip9b7UZTq3VD2YCsO6N+pUt8CuHbxtGQ9dKptv8asXc/qJepA5TjnW TF/0NbPgIfUi9bxyULGn+T4chq7TZi3vYmTKaSPZsNRBbfW9JPo8whxE5fOFo55VxL+C QUqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=jani.nikula@intel.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of jani.nikula@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=jani.nikula@intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,448,1511856000"; d="scan'208";a="27552163" From: Jani Nikula To: Greg KH Cc: Lukas Bulwahn , Knut Omang , Ozan Alpay , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , sil2review@lists.osadl.org, kernelnewbies@kernelnewbies.org, David Airlie , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , llvmlinux@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: clang warning: implicit conversion in intel_ddi.c:1481 In-Reply-To: <20180202131328.GA4456@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180201180240.GA28042@kroah.com> <87372jkcu5.fsf@intel.com> <20180202100613.GA21492@kroah.com> <87h8qzisbt.fsf@intel.com> <20180202131328.GA4456@kroah.com> Date: Fri, 02 Feb 2018 16:37:55 +0200 Message-ID: <871si3ihj0.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1591285684265715697?= X-GMAIL-MSGID: =?utf-8?q?1591300365255234714?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, 02 Feb 2018, Greg KH wrote: > On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: >> >> +Knut, Fengguang >> >> On Fri, 02 Feb 2018, Greg KH wrote: >> > - If clang now builds the kernel "cleanly", yes, I want to take >> > warning fixes in the stable tree. And even better yet, if you >> > keep working to ensure the tree is "clean", that would be >> > wonderful. >> >> So we can run sparse using 'make C=1' and friends, or other static >> analysis tools using 'make CHECK=foo C=1', as long as the passed command >> line params work. There was work by Knut to extend this make checker >> stuff [1]. Since mixing different HOSTCC's in a single workdir seems >> like a bad idea, I wonder how hard it would be to make clang work like >> this: >> >> $ make CHECK=clang C=1 >> >> Or using Knut's wrapper. Feels like that could increase the use of clang >> for static analysis of patches. > > Why not just build with clang itself: > make CC=clang Same as HOSTCC, mixing different CC's in a single build dir seems like a bad idea. Sure, everyone can setup a separate build dir for clang, but IMHO having 'make CHECK=clang C=1' work has least resistance. YMMV. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center