All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Andrew Geissler <geissonator@gmail.com>,
	Michael Tritz <mtritz@us.ibm.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: Host factory reset - version priorities
Date: Fri, 15 Dec 2017 15:40:50 +1100	[thread overview]
Message-ID: <871sjwwqlp.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <CALLMt=pVW5N4=PbKaM8XOws-vQcii23vCutC4zPzpW_5tmH0-w@mail.gmail.com>

Andrew Geissler <geissonator@gmail.com> writes:
> On Mon, Dec 4, 2017 at 10:43 PM, Michael Tritz <mtritz@us.ibm.com> wrote:
>> What should be happening on a host factory reset?
>>
>> Suppose we have a machine with two host versions uploaded - one active, one
>> not. Currently, the host factory reset will clear the persistence files with
>> which we store the priority information for these versions. The next time
>> the host software updater is started, both versions are left with priority
>> of 255, and one of the two (maybe it's random, maybe it's based on upload
>> order) is selected as the active host version.
>>
>> Is this the desired behavior? Would it be better to instead retain the
>> version priority through a reset, or is clearing that setting under the
>> scope of "restoring factory settings"?
>
> I do not thing we want to lose the priority on a factory reset.  We
> have to ensure we always
> use the firmware level that the user last activated, no matter what.
> The "spirit" of a factory
> reset is to clear any changes done by the user to defaults of the
> firmware.  Ensuring we boot with the right
> level of firmware is still required after a factory reset.

I'm with Andrew on this one, I would think that it should keep the
current firmware versions and the current priorities of them.

*IF* we had the concept of something like a factory or golden image,
then *maybe* it would make sense to reset to it. But considering we
don't have that (at least currently), I think the behaviour should be to
reset everything as if the machine came out of the factory with the
currently active images loaded (i.e. do *not* reset priorities).

-- 
Stewart Smith
OPAL Architect, IBM.

      reply	other threads:[~2017-12-15  4:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  4:43 Host factory reset - version priorities Michael Tritz
2017-12-12 19:14 ` Andrew Geissler
2017-12-15  4:40   ` Stewart Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sjwwqlp.fsf@linux.vnet.ibm.com \
    --to=stewart@linux.vnet.ibm.com \
    --cc=geissonator@gmail.com \
    --cc=mtritz@us.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.