From: Markus Armbruster <armbru@redhat.com>
To: geoff--- via Qemu-devel <qemu-devel@nongnu.org>
Cc: geoff@hostfission.com, pbonzini@redhat.com,
Ladi Prosek <lprosek@redhat.com>,
marcandre.lureau@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling
Date: Tue, 14 Nov 2017 08:37:53 +0100 [thread overview]
Message-ID: <871sl1wbse.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <546207b7d08628804461a97728ad1c06@hostfission.com> (geoff's message of "Tue, 14 Nov 2017 04:47:23 +1100")
geoff--- via Qemu-devel <qemu-devel@nongnu.org> writes:
> On 2017-11-14 04:27, Markus Armbruster wrote:
>> Ladi Prosek <lprosek@redhat.com> writes:
>>
>>> Adds a rollback path to ivshmem_enable_irqfd() and fixes
>>> ivshmem_disable_irqfd() to bail if irqfd has not been enabled.
>>>
>>> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
>>
>> Is this a theoretical bug, or can you trigger it?
>
> It is reproducible, I can trigger it by simply unloading the windows
> driver and then attempting to re-load it.
Adding that to the commit message would be nice. You then can add my
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2017-11-14 7:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 17:34 [Qemu-devel] [PATCH 0/3] ivshmem: MSI bug fixes Ladi Prosek
2017-11-10 17:34 ` [Qemu-devel] [PATCH 1/3] ivshmem: Don't update non-existent MSI routes Ladi Prosek
2017-11-10 18:10 ` Marc-André Lureau
2017-11-10 20:04 ` geoff
2017-11-13 14:22 ` Markus Armbruster
2017-11-13 14:38 ` Ladi Prosek
2017-11-13 17:26 ` Markus Armbruster
2017-11-10 17:34 ` [Qemu-devel] [PATCH 2/3] ivshmem: Always remove irqfd notifiers Ladi Prosek
2017-11-13 14:36 ` Markus Armbruster
2017-11-13 14:40 ` Ladi Prosek
2017-11-10 17:34 ` [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling Ladi Prosek
2017-11-13 17:27 ` Markus Armbruster
2017-11-13 17:47 ` geoff
2017-11-14 7:37 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sl1wbse.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=geoff@hostfission.com \
--cc=lprosek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.