All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/wrapper: fake __DATE_ and __TIME__ for older gcc
Date: Sun, 22 Oct 2017 16:10:07 +0200	[thread overview]
Message-ID: <871slvb7eo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171021203102.14520-1-arnout@mind.be> (Arnout Vandecappelle's message of "Sat, 21 Oct 2017 22:31:02 +0200")

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

Hi,

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Starting with version 7, gcc automatically recognises and enforces the
 > environment variable SOURCE_DATE_EPOCH, and fakes __DATE__ and __TIME__
 > accordingly, to produce reproducible builds (at least in regards to date
 > and time).

 > However, older gcc versions do not offer this feature.

 > So, we use our toolchain wrapper to force-feed __DATE__ and __TIME__ as
 > macros, which will take precedence over those that gcc may compute
 > itself. We compute them according to the specs:
 >     https://reproducible-builds.org/specs/source-date-epoch/
 >     https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html

 > Since we define macros otherwise internal to gcc, we have to tell it not
 > to warn about that. The -Wno-builtin-macro-redefined flag was introduced
 > in gcc-4.4.0. Therefore, we make BR2_REPRODUCIBLE depend on GCC >= 4.4.

 > gcc-7 will ignore SOURCE_DATE_EPOCH when __DATE__ and __TIME__ are
 > user-defined. Anyway, this is of no consequence: whether __DATE__ and
 > __TIME__ or SOURCE_DATE_EPOCH takes precedence, it would yield the
 > exact same end result since we use the same logic to compute it. Note
 > that we didn't copy the code for it from gcc so using the same logic
 > doesn't imply that we're inheriting GPL-3.0.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: J?r?me Pouiller <jezz@sysmic.org>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Arnout Vandecappelle <arnout@mind.be>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > [Arnout: rewrite commit message]
 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2017-10-22 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-21 20:31 [Buildroot] [PATCH] toolchain/wrapper: fake __DATE_ and __TIME__ for older gcc Arnout Vandecappelle
2017-10-21 20:38 ` Yann E. MORIN
2017-10-22 14:10 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871slvb7eo.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.