From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib: Fixup __gem_create() to be 64b safe.
Date: Tue, 03 Oct 2017 17:05:55 +0300 [thread overview]
Message-ID: <871smk498c.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171003135455.24023-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> We want to create very large objects, larger than the 2G limit imposed
> by using ints.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviwed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> lib/ioctl_wrappers.c | 2 +-
> lib/ioctl_wrappers.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 1b483706..87511fc6 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -551,7 +551,7 @@ uint32_t gem_create_stolen(int fd, uint64_t size)
> return create.handle;
> }
>
> -int __gem_create(int fd, int size, uint32_t *handle)
> +int __gem_create(int fd, uint64_t size, uint32_t *handle)
> {
> struct drm_i915_gem_create create = {
> .size = size,
> diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
> index 6ed65fad..1663b7f8 100644
> --- a/lib/ioctl_wrappers.h
> +++ b/lib/ioctl_wrappers.h
> @@ -73,7 +73,7 @@ void gem_sync(int fd, uint32_t handle);
> bool gem_create__has_stolen_support(int fd);
> uint32_t __gem_create_stolen(int fd, uint64_t size);
> uint32_t gem_create_stolen(int fd, uint64_t size);
> -int __gem_create(int fd, int size, uint32_t *handle);
> +int __gem_create(int fd, uint64_t size, uint32_t *handle);
> uint32_t gem_create(int fd, uint64_t size);
> void gem_execbuf_wr(int fd, struct drm_i915_gem_execbuffer2 *execbuf);
> int __gem_execbuf_wr(int fd, struct drm_i915_gem_execbuffer2 *execbuf);
> --
> 2.14.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-03 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 13:54 [PATCH igt] lib: Fixup __gem_create() to be 64b safe Chris Wilson
2017-10-03 14:05 ` Mika Kuoppala [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-03 13:56 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871smk498c.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.