From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 06/18] drm: use ARRAY_SIZE Date: Mon, 02 Oct 2017 10:43:18 +0300 Message-ID: <871smm6lm1.fsf@intel.com> References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-7-jeremy.lefaure@lse.epita.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171001193101.8898-7-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , David Airlie , Patrik Jakobsson , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Ben Skeggs Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?utf-8?B?SsOpcsOpbXk=?= Lefaure , intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: amd-gfx.lists.freedesktop.org T24gU3VuLCAwMSBPY3QgMjAxNywgSsOpcsOpbXkgTGVmYXVyZSA8amVyZW15LmxlZmF1cmVAbHNl LmVwaXRhLmZyPiB3cm90ZToKPiBVc2luZyB0aGUgQVJSQVlfU0laRSBtYWNybyBpbXByb3ZlcyB0 aGUgcmVhZGFiaWxpdHkgb2YgdGhlIGNvZGUuIEFsc28sCj4gaXQgaXMgbm90IGFsd2F5cyB1c2Vm dWwgdG8gdXNlIGEgdmFyaWFibGUgdG8gc3RvcmUgdGhpcyBjb25zdGFudAo+IGNhbGN1bGF0ZWQg YXQgY29tcGlsZSB0aW1lIG5vciB0byByZS1pbnZlbnQgdGhlIEFSUkFZX1NJWkUgbWFjcm8uCj4K PiBGb3VuZCB3aXRoIENvY2NpbmVsbGUgd2l0aCB0aGUgZm9sbG93aW5nIHNlbWFudGljIHBhdGNo Ogo+IEByIGRlcGVuZHMgb24gKG9yZyB8fCByZXBvcnQpQAo+IHR5cGUgVDsKPiBUW10gRTsKPiBw b3NpdGlvbiBwOwo+IEBACj4gKAo+ICAoc2l6ZW9mKEUpQHAgL3NpemVvZigqRSkpCj4gfAo+ICAo c2l6ZW9mKEUpQHAgL3NpemVvZihFWy4uLl0pKQo+IHwKPiAgKHNpemVvZihFKUBwIC9zaXplb2Yo VCkpCj4gKQo+Cj4gU2lnbmVkLW9mZi1ieTogSsOpcsOpbXkgTGVmYXVyZSA8amVyZW15LmxlZmF1 cmVAbHNlLmVwaXRhLmZyPgoKUGxlYXNlIHNwbGl0IHRoaXMgdXAuCgpQYXRjaCAxOgo+ICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhfMC5jICAgICAgICAgICB8ICA5ICsrKysrLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5jICAgICAgICAgICB8ICA5 ICsrKysrLS0tLQoKUGF0Y2ggMjoKPiAgZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9wc2JfaW50ZWxf c2R2by5jICAgICAgICAgfCAgOSArKysrLS0tLS0KClBhdGNoIDM6Cj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2d2dC92Z3B1LmMgICAgICAgICAgICAgICAgIHwgIDMgKystCgpQYXRjaCA0Ogo+ICBk cml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9iaW9zL2luaXQuYyB8ICA3ICsrKyst LS0KClBhdGNoIDU6Cj4gIGRyaXZlcnMvZ3B1L2RybS92aWEvdmlhX3ZlcmlmaWVyLmMgICAgICAg ICAgICAgIHwgMTAgKysrKy0tLS0tLQoKQlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVs IE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750891AbdJBHnw convert rfc822-to-8bit (ORCPT ); Mon, 2 Oct 2017 03:43:52 -0400 Received: from mga03.intel.com ([134.134.136.65]:4250 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdJBHnv (ORCPT ); Mon, 2 Oct 2017 03:43:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,468,1500966000"; d="scan'208";a="905782077" From: Jani Nikula To: =?utf-8?B?SsOpcsOpbXk=?= Lefaure , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , David Airlie , Patrik Jakobsson , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Ben Skeggs Cc: =?utf-8?B?SsOpcsOpbXk=?= Lefaure , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH 06/18] drm: use ARRAY_SIZE In-Reply-To: <20171001193101.8898-7-jeremy.lefaure@lse.epita.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-7-jeremy.lefaure@lse.epita.fr> Date: Mon, 02 Oct 2017 10:43:18 +0300 Message-ID: <871smm6lm1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 01 Oct 2017, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time nor to re-invent the ARRAY_SIZE macro. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure Please split this up. Patch 1: > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 9 +++++---- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 9 +++++---- Patch 2: > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 9 ++++----- Patch 3: > drivers/gpu/drm/i915/gvt/vgpu.c | 3 ++- Patch 4: > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 7 ++++--- Patch 5: > drivers/gpu/drm/via/via_verifier.c | 10 ++++------ BR, Jani. -- Jani Nikula, Intel Open Source Technology Center