Re: [PATCH i-g-t] tools/intel_vbt_decode: Fix decoding of child device structure

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 16 Aug 2017, Clint Taylor <clinton.a.taylor@intel.com> wrote:
> This patch fixes the alignment. I spotted another issue with teh 
> structure and will fix it once this one is merged.

I'm sure there are plenty of issues; patches welcome!

BR,
Jani.

>
> Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
> Tested-by: Clint Taylor <Clinton.A.Taylor@intel.com>
>
>
> On 08/16/2017 07:20 AM, ville.syrjala@linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Fix decoding of the start of the child device structure. I had
>> accidentally duplicated the "device class/type" member and forgot to
>> include the add-in offset later. Fortunately both were two byte fields
>> so they effectively cancelled each other out and thus the remainder of
>> the child device structure was being decoded correctly. But of course
>> anything sitting between these two fieds was being decoded incorrectly.
>>
>> Fixes: 86a546f6f798 ("tools/intel_bios_reader: Dump out more information from the child device structure")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> ---
>>   tools/intel_bios.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/intel_bios.h b/tools/intel_bios.h
>> index ca0d2c587120..f2ccb55ab6c3 100644
>> --- a/tools/intel_bios.h
>> +++ b/tools/intel_bios.h
>> @@ -273,7 +273,6 @@ struct child_device_config {
>>   struct efp_child_device_config {
>>   	uint16_t handle;
>>   	uint16_t device_type;
>> -	uint16_t device_class;
>>   	uint8_t i2c_speed;
>>   	uint8_t dp_onboard_redriver; /* 158 */
>>   	uint8_t dp_ondock_redriver; /* 158 */
>> @@ -289,6 +288,7 @@ struct efp_child_device_config {
>>   	uint8_t skip1:4;
>>   	uint8_t slave_port; /*  202 */
>>   	uint8_t skip2;
>> +	uint16_t addin_offset;
>>   	uint8_t port;
>>   	uint8_t i2c_pin; /* for add-in card */
>>   	uint8_t slave_addr; /* for add-in card */
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx