From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: Reduce scope of 'state' variable Date: Thu, 15 Jun 2017 14:09:07 +0300 Message-ID: <871sqlzewc.fsf@intel.com> References: <20170615104142.GA29276@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B506D6E6D4 for ; Thu, 15 Jun 2017 11:09:11 +0000 (UTC) In-Reply-To: <20170615104142.GA29276@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dawid Kurek , Daniel Vetter , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNSBKdW4gMjAxNywgRGF3aWQgS3VyZWsgPGRhd2lrdXJAZ21haWwuY29tPiB3cm90 ZToKPiBTbWFsbGVyIHNjb3BlIHJlZHVjZXMgdmlzaWJpbGl0eSBvZiB2YXJpYWJsZSBhbmQgbWFr ZXMgdXNhZ2Ugb2YKPiB1bmluaXRpYWxpemVkIHZhcmlhYmxlIGxlc3MgcG9zc2libGUuCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCA1ICsrKy0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMK PiBpbmRleCBmMzI1MDZhLi5lYTVhOWE3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTEw OCwxMCArMTA4LDExIEBAIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICoKPiAgZHJtX2F0b21pY19z dGF0ZV9hbGxvYyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX21v ZGVfY29uZmlnICpjb25maWcgPSAmZGV2LT5tb2RlX2NvbmZpZzsKPiAtCXN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZTsKPiAgCj4gIAlpZiAoIWNvbmZpZy0+ZnVuY3MtPmF0b21pY19zdGF0 ZV9hbGxvYykgewo+IC0JCXN0YXRlID0ga3phbGxvYyhzaXplb2YoKnN0YXRlKSwgR0ZQX0tFUk5F TCk7Cj4gKwkJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlCj4gKwkJCT0ga3phbGxvYyhz aXplb2YoKnN0YXRlKSwgR0ZQX0tFUk5FTCk7CgpTZXBhcmF0ZSBkZWNsYXJhdGlvbiBhbmQgaW5p dGlhbGl6YXRpb24gd291bGQgbGVhZCB0byBhIGNsZWFuZXIgcGF0Y2gKYW5kIHJlc3VsdC4KCkJS LApKYW5pLgoKPiArCj4gIAkJaWYgKCFzdGF0ZSkKPiAgCQkJcmV0dXJuIE5VTEw7Cj4gIAkJaWYg KGRybV9hdG9taWNfc3RhdGVfaW5pdChkZXYsIHN0YXRlKSA8IDApIHsKCi0tIApKYW5pIE5pa3Vs YSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbdFOLJM (ORCPT ); Thu, 15 Jun 2017 07:09:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:56848 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbdFOLJL (ORCPT ); Thu, 15 Jun 2017 07:09:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,343,1493708400"; d="scan'208";a="868239312" From: Jani Nikula To: Dawid Kurek , Daniel Vetter , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Reduce scope of 'state' variable In-Reply-To: <20170615104142.GA29276@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170615104142.GA29276@gmail.com> Date: Thu, 15 Jun 2017 14:09:07 +0300 Message-ID: <871sqlzewc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2017, Dawid Kurek wrote: > Smaller scope reduces visibility of variable and makes usage of > uninitialized variable less possible. > --- > drivers/gpu/drm/drm_atomic.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index f32506a..ea5a9a7 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -108,10 +108,11 @@ struct drm_atomic_state * > drm_atomic_state_alloc(struct drm_device *dev) > { > struct drm_mode_config *config = &dev->mode_config; > - struct drm_atomic_state *state; > > if (!config->funcs->atomic_state_alloc) { > - state = kzalloc(sizeof(*state), GFP_KERNEL); > + struct drm_atomic_state *state > + = kzalloc(sizeof(*state), GFP_KERNEL); Separate declaration and initialization would lead to a cleaner patch and result. BR, Jani. > + > if (!state) > return NULL; > if (drm_atomic_state_init(dev, state) < 0) { -- Jani Nikula, Intel Open Source Technology Center