From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dIyLf-0005M9-OE for mharc-qemu-trivial@gnu.org; Thu, 08 Jun 2017 10:23:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyLd-0005K0-AG for qemu-trivial@nongnu.org; Thu, 08 Jun 2017 10:23:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIyLc-0004vC-GX for qemu-trivial@nongnu.org; Thu, 08 Jun 2017 10:23:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50280) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIyLa-0004te-G4; Thu, 08 Jun 2017 10:23:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13C61C0E640B; Thu, 8 Jun 2017 14:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 13C61C0E640B Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=quintela@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 13C61C0E640B Received: from localhost (ovpn-117-154.ams2.redhat.com [10.36.117.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 275DE7F1CB; Thu, 8 Jun 2017 14:23:34 +0000 (UTC) From: Juan Quintela To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Paolo Bonzini , Bharata B Rao , Eduardo Habkost , Igor Mammedov , David Gibson , Andrew Jones In-Reply-To: <1496927934-21815-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 15:18:54 +0200") References: <1496927934-21815-1-git-send-email-thuth@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Thu, 08 Jun 2017 16:23:34 +0200 Message-ID: <871squblsp.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 08 Jun 2017 14:23:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [PATCH] hw/cpu: core.c can be compiled as common object X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 14:23:42 -0000 Thomas Huth wrote: > There does not seem to be any target specific code in core.c, so we can > put it into "common-obj" instead of "obj" to compile it only once for > all targets. > > Signed-off-by: Thomas Huth It compiles. I can't see anything that is target dependent on core.c. So Reviewed-by: Juan Quintela From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIyLb-0005HS-DR for qemu-devel@nongnu.org; Thu, 08 Jun 2017 10:23:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIyLa-0004uK-Mn for qemu-devel@nongnu.org; Thu, 08 Jun 2017 10:23:39 -0400 From: Juan Quintela In-Reply-To: <1496927934-21815-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 15:18:54 +0200") References: <1496927934-21815-1-git-send-email-thuth@redhat.com> Reply-To: quintela@redhat.com Date: Thu, 08 Jun 2017 16:23:34 +0200 Message-ID: <871squblsp.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Paolo Bonzini , Bharata B Rao , Eduardo Habkost , Igor Mammedov , David Gibson , Andrew Jones Thomas Huth wrote: > There does not seem to be any target specific code in core.c, so we can > put it into "common-obj" instead of "obj" to compile it only once for > all targets. > > Signed-off-by: Thomas Huth It compiles. I can't see anything that is target dependent on core.c. So Reviewed-by: Juan Quintela