From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Tue, 23 May 2017 08:19:58 +0000 Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Message-Id: <871srgouhd.fsf@intel.com> List-Id: References: <20170519110203.19417-1-colin.king@canonical.com> <874lwhoxyk.fsf@intel.com> <20170519194759.gfiefx6xwrnrjn3x@mwanda> <874lwg8v9n.fsf@eliezer.anholt.net> <20170519201641.fwnoakx5gew7wo5t@mwanda> In-Reply-To: <20170519201641.fwnoakx5gew7wo5t@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Eric Anholt Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Colin King On Fri, 19 May 2017, Dan Carpenter wrote: > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: >> OK, that's definitely not how I've read the >> Documentation/process/submitting-patches.rst description of the Fixes >> tag, which talks about bugs found with git bisect and things that should >> go to -stable. I would not have considered what this patch is changing >> to be a bug. > > True. I don't consider this a bug either. I wouldn't have included a > Fixes tag. > > I pretty much agree with the submitting-patches.rst except it should > probably say to include it on more stuff. Fixes: tags are required for > all bugfixes to netdev for example. We use Fixes: in drm/i915 to basically indicate that the referenced commit has a bug that actually needs to be fixed, this patch is the fix, and should go wherever the referenced commit goes. Annotating typo fixes and missing static keywords and such is just noise from *our* POV, and need to be filtered out. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Date: Tue, 23 May 2017 11:19:58 +0300 Message-ID: <871srgouhd.fsf@intel.com> References: <20170519110203.19417-1-colin.king@canonical.com> <874lwhoxyk.fsf@intel.com> <20170519194759.gfiefx6xwrnrjn3x@mwanda> <874lwg8v9n.fsf@eliezer.anholt.net> <20170519201641.fwnoakx5gew7wo5t@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 347146E123 for ; Tue, 23 May 2017 08:16:34 +0000 (UTC) In-Reply-To: <20170519201641.fwnoakx5gew7wo5t@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Eric Anholt Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Colin King List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxOSBNYXkgMjAxNywgRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUu Y29tPiB3cm90ZToKPiBPbiBGcmksIE1heSAxOSwgMjAxNyBhdCAwMTowODoyMFBNIC0wNzAwLCBF cmljIEFuaG9sdCB3cm90ZToKPj4gT0ssIHRoYXQncyBkZWZpbml0ZWx5IG5vdCBob3cgSSd2ZSBy ZWFkIHRoZQo+PiBEb2N1bWVudGF0aW9uL3Byb2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdCBk ZXNjcmlwdGlvbiBvZiB0aGUgRml4ZXMKPj4gdGFnLCB3aGljaCB0YWxrcyBhYm91dCBidWdzIGZv dW5kIHdpdGggZ2l0IGJpc2VjdCBhbmQgdGhpbmdzIHRoYXQgc2hvdWxkCj4+IGdvIHRvIC1zdGFi bGUuICBJIHdvdWxkIG5vdCBoYXZlIGNvbnNpZGVyZWQgd2hhdCB0aGlzIHBhdGNoIGlzIGNoYW5n aW5nCj4+IHRvIGJlIGEgYnVnLgo+Cj4gVHJ1ZS4gIEkgZG9uJ3QgY29uc2lkZXIgdGhpcyBhIGJ1 ZyBlaXRoZXIuICBJIHdvdWxkbid0IGhhdmUgaW5jbHVkZWQgYQo+IEZpeGVzIHRhZy4KPgo+IEkg cHJldHR5IG11Y2ggYWdyZWUgd2l0aCB0aGUgc3VibWl0dGluZy1wYXRjaGVzLnJzdCBleGNlcHQg aXQgc2hvdWxkCj4gcHJvYmFibHkgc2F5IHRvIGluY2x1ZGUgaXQgb24gbW9yZSBzdHVmZi4gIEZp eGVzOiB0YWdzIGFyZSByZXF1aXJlZCBmb3IKPiBhbGwgYnVnZml4ZXMgdG8gbmV0ZGV2IGZvciBl eGFtcGxlLgoKV2UgdXNlIEZpeGVzOiBpbiBkcm0vaTkxNSB0byBiYXNpY2FsbHkgaW5kaWNhdGUg dGhhdCB0aGUgcmVmZXJlbmNlZApjb21taXQgaGFzIGEgYnVnIHRoYXQgYWN0dWFsbHkgbmVlZHMg dG8gYmUgZml4ZWQsIHRoaXMgcGF0Y2ggaXMgdGhlIGZpeCwKYW5kIHNob3VsZCBnbyB3aGVyZXZl ciB0aGUgcmVmZXJlbmNlZCBjb21taXQgZ29lcy4gQW5ub3RhdGluZyB0eXBvIGZpeGVzCmFuZCBt aXNzaW5nIHN0YXRpYyBrZXl3b3JkcyBhbmQgc3VjaCBpcyBqdXN0IG5vaXNlIGZyb20gKm91ciog UE9WLCBhbmQKbmVlZCB0byBiZSBmaWx0ZXJlZCBvdXQuCgpCUiwKSmFuaS4KCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966598AbdEWIQh (ORCPT ); Tue, 23 May 2017 04:16:37 -0400 Received: from mga06.intel.com ([134.134.136.31]:40785 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966292AbdEWIQe (ORCPT ); Tue, 23 May 2017 04:16:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,381,1491289200"; d="scan'208";a="860304897" From: Jani Nikula To: Dan Carpenter , Eric Anholt Cc: Colin King , Tom Cooksey , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static In-Reply-To: <20170519201641.fwnoakx5gew7wo5t@mwanda> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170519110203.19417-1-colin.king@canonical.com> <874lwhoxyk.fsf@intel.com> <20170519194759.gfiefx6xwrnrjn3x@mwanda> <874lwg8v9n.fsf@eliezer.anholt.net> <20170519201641.fwnoakx5gew7wo5t@mwanda> Date: Tue, 23 May 2017 11:19:58 +0300 Message-ID: <871srgouhd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May 2017, Dan Carpenter wrote: > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: >> OK, that's definitely not how I've read the >> Documentation/process/submitting-patches.rst description of the Fixes >> tag, which talks about bugs found with git bisect and things that should >> go to -stable. I would not have considered what this patch is changing >> to be a bug. > > True. I don't consider this a bug either. I wouldn't have included a > Fixes tag. > > I pretty much agree with the submitting-patches.rst except it should > probably say to include it on more stuff. Fixes: tags are required for > all bugfixes to netdev for example. We use Fixes: in drm/i915 to basically indicate that the referenced commit has a bug that actually needs to be fixed, this patch is the fix, and should go wherever the referenced commit goes. Annotating typo fixes and missing static keywords and such is just noise from *our* POV, and need to be filtered out. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center