Re: A sector-of-mismatch warning patch (was Re: Fault tolerance with badblocks)

[Nix <nix@esperi.org.uk>]

On 16 May 2017, NeilBrown spake thusly:

> Actually, I have another caveat.  I don't think we want these messages
> during initial resync, or any resync.  Only during a 'check' or
> 'repair'.
> So add a check for MD_RECOVERY_REQUESTED or maybe for
>   sh->sectors >= conf->mddev->recovery_cp

I completely agree, but it's already inside MD_RECOVERY_CHECK:

if (test_bit(MD_RECOVERY_CHECK, &conf->mddev->recovery)) {
        /* don't try to repair!! */
        set_bit(STRIPE_INSYNC, &sh->state);
        pr_warn_ratelimited("%s: mismatch sector in range "
                            "%llu-%llu\n", mdname(conf->mddev),
                            (unsigned long long) sh->sector,
                            (unsigned long long) sh->sector +
                            STRIPE_SECTORS);
} else {

Doesn't that already mean that someone has explicitly triggered a check
action?