From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Vincent.Bernat@exoscale.ch>) id 1c8qd7-0002ma-B5
	for qemu-devel@nongnu.org; Mon, 21 Nov 2016 10:35:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Vincent.Bernat@exoscale.ch>) id 1c8qd4-0006gr-5J
	for qemu-devel@nongnu.org; Mon, 21 Nov 2016 10:35:37 -0500
Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35193)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Vincent.Bernat@exoscale.ch>)
	id 1c8qd3-0006fI-NL
	for qemu-devel@nongnu.org; Mon, 21 Nov 2016 10:35:34 -0500
Received: by mail-wm0-x22d.google.com with SMTP id a197so153661313wmd.0
	for <qemu-devel@nongnu.org>; Mon, 21 Nov 2016 07:35:31 -0800 (PST)
From: Vincent Bernat <Vincent.Bernat@exoscale.ch>
References: <20161119223003.GD10378@var.home>
	<20161120084136.721-1-Vincent.Bernat@exoscale.ch>
	<20161121144616.GG15478@stefanha-x1.localdomain>
Date: Mon, 21 Nov 2016 16:35:28 +0100
In-Reply-To: <20161121144616.GG15478@stefanha-x1.localdomain> (Stefan
	Hajnoczi's message of "Mon, 21 Nov 2016 14:46:16 +0000")
Message-ID: <871sy4dewv.fsf@luffy.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Samuel Thibault <samuel.thibault@gnu.org>, Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>, "H. Peter Anvin" <hpa@zytor.com>

 =E2=9D=A6 21 novembre 2016 14:46 GMT, Stefan Hajnoczi <stefanha@redhat.com=
>=C2=A0:

> The commit description says it would be "far more complex" to implement
> netascii.  Is the LF -> CR LF and CR -> CR NUL transformation so hard?

Currently, the code uses lseek to send each block. It is just a matter
of doing nr_block*512. If there is a transformation, this cannot work
this way. But this can be done, we'll just have to maintain an offset.

Not knowing the final size is not a problem, just send back 0 as the
size.
--=20
Vincent Bernat =E2=80=94 Vincent.Bernat@exoscale.ch
=E2=9D=AC=E2=9D=B1 https://www.exoscale.ch