From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 0/8] qdev class properties + abstract class support on device-list-properties
Date: Fri, 04 Nov 2016 16:52:00 +0100 [thread overview]
Message-ID: <871syr450f.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1477705687-31175-1-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 28 Oct 2016 23:47:59 -0200")
Just minor comments, do series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
I'd like to see a clearer need for PATCH 7, though. Shouldn't hold up
the rest.
prev parent reply other threads:[~2016-11-04 15:52 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 1:47 [Qemu-devel] [PATCH v4 0/8] qdev class properties + abstract class support on device-list-properties Eduardo Habkost
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove duplicate "bv" property Eduardo Habkost
2016-11-04 11:22 ` Markus Armbruster
2016-11-04 15:10 ` Markus Armbruster
2016-11-04 15:56 ` Andreas Färber
2016-11-04 16:07 ` Eduardo Habkost
2016-11-04 16:11 ` Andreas Färber
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_abort to catch errors Eduardo Habkost
2016-10-31 10:14 ` Igor Mammedov
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 3/8] qdev: device_class_set_props() function Eduardo Habkost
2016-11-01 15:02 ` Igor Mammedov
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 4/8] qdev: Extract property-default code to qdev_property_set_to_default() Eduardo Habkost
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 5/8] qdev: Register static properties as class properties Eduardo Habkost
2016-10-31 12:06 ` Igor Mammedov
2016-11-04 15:22 ` Markus Armbruster
2016-11-04 16:00 ` Eduardo Habkost
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 6/8] qom: object_class_property_iter_init() function Eduardo Habkost
2016-10-31 13:45 ` Igor Mammedov
2016-11-04 15:31 ` Markus Armbruster
2016-10-29 1:48 ` [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties Eduardo Habkost
2016-10-31 14:07 ` Igor Mammedov
2016-10-31 14:36 ` Eduardo Habkost
2016-11-04 15:45 ` Markus Armbruster
2016-11-04 16:04 ` Eduardo Habkost
2016-11-07 8:09 ` Markus Armbruster
2016-11-07 12:38 ` Eduardo Habkost
2016-11-07 14:40 ` Markus Armbruster
2016-11-07 17:11 ` Eduardo Habkost
2016-11-08 7:29 ` Markus Armbruster
2016-11-11 12:17 ` Jiri Denemark
2016-11-11 12:34 ` Eduardo Habkost
2016-11-11 14:29 ` Markus Armbruster
2016-11-07 12:45 ` Halil Pasic
2016-11-07 13:05 ` Eduardo Habkost
2016-11-07 14:48 ` Halil Pasic
2016-11-07 15:01 ` Daniel P. Berrange
2016-11-07 15:51 ` Markus Armbruster
2016-11-07 17:27 ` Eduardo Habkost
2016-11-07 17:41 ` Daniel P. Berrange
2016-11-07 18:03 ` Eduardo Habkost
2016-11-07 18:08 ` Daniel P. Berrange
2016-11-07 18:28 ` Eduardo Habkost
2016-11-08 7:37 ` Markus Armbruster
2016-11-08 10:09 ` Daniel P. Berrange
2016-11-08 14:35 ` Markus Armbruster
2016-11-08 16:16 ` Eduardo Habkost
2016-11-08 10:11 ` Halil Pasic
2016-10-29 1:48 ` [Qemu-arm] [PATCH v4 8/8] qdev: Warning about using qdev_property_add_static() in new code Eduardo Habkost
2016-10-29 1:48 ` [Qemu-devel] " Eduardo Habkost
2016-10-31 14:05 ` [Qemu-arm] " Igor Mammedov
2016-10-31 14:05 ` [Qemu-devel] " Igor Mammedov
2016-11-04 15:52 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871syr450f.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.