From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bxSOk-0008DA-TF for kexec@lists.infradead.org; Fri, 21 Oct 2016 05:29:43 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <1477012516-20470-1-git-send-email-f.fainelli@gmail.com> <20161020.215410.650162338407203719.davem@davemloft.net> Date: Fri, 21 Oct 2016 00:26:55 -0500 In-Reply-To: <20161020.215410.650162338407203719.davem@davemloft.net> (David Miller's message of "Thu, 20 Oct 2016 21:54:10 -0400 (EDT)") Message-ID: <871szagtls.fsf@xmission.com> MIME-Version: 1.0 Subject: Re: [PATCH] kexec: Export kexec_in_progress to modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: David Miller Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au David Miller writes: > From: Florian Fainelli > Date: Thu, 20 Oct 2016 18:15:16 -0700 > >> The bcm_sf2 driver uses kexec_in_progress to know whether it can power >> down an integrated PHY during shutdown, and can be built as a module. >> Other modules may be using this in the future, so export it. >> >> Fixes: 2399d6143f85 ("net: dsa: bcm_sf2: Prevent GPHY shutdown for kexec'd kernels") >> Signed-off-by: Florian Fainelli >> --- >> Eric, David, Stephen, >> >> The offending commit is in David's net.git tree, so it would probably make >> sense to route the fix through the same tree. > > Ok, I'll apply this, thanks Florian. Florian I am completely confused why any driver would want to do this. A reboot is semantically identical to a kexec restart. Always has been. That is pwoering down your hardware during reboot is not safe. The only thing that might save you is the hardware reset line being toggled at which point your hardware is powered up again anyway. So as far as I can tell you are advocating for a change to support a driver doing something that is completely pointless. So no let's not export this symbol. Please fix the driver to do something less pointless instead. Eric _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbcJUF3I (ORCPT ); Fri, 21 Oct 2016 01:29:08 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:38792 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbcJUF3G (ORCPT ); Fri, 21 Oct 2016 01:29:06 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: David Miller Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au References: <1477012516-20470-1-git-send-email-f.fainelli@gmail.com> <20161020.215410.650162338407203719.davem@davemloft.net> Date: Fri, 21 Oct 2016 00:26:55 -0500 In-Reply-To: <20161020.215410.650162338407203719.davem@davemloft.net> (David Miller's message of "Thu, 20 Oct 2016 21:54:10 -0400 (EDT)") Message-ID: <871szagtls.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1bxSO7-0001cU-CA;;;mid=<871szagtls.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=75.170.125.99;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/EJIoVaS8VnSfObh/id+Er0W1deLckUg4= X-SA-Exim-Connect-IP: 75.170.125.99 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;David Miller X-Spam-Relay-Country: X-Spam-Timing: total 174 ms - load_scoreonly_sql: 0.07 (0.0%), signal_user_changed: 3.6 (2.1%), b_tie_ro: 2.5 (1.4%), parse: 0.97 (0.6%), extract_message_metadata: 11 (6.4%), get_uri_detail_list: 1.17 (0.7%), tests_pri_-1000: 4.8 (2.8%), tests_pri_-950: 1.28 (0.7%), tests_pri_-900: 1.02 (0.6%), tests_pri_-400: 20 (11.2%), check_bayes: 19 (10.7%), b_tokenize: 5 (3.1%), b_tok_get_all: 6 (3.6%), b_comp_prob: 2.0 (1.2%), b_tok_touch_all: 2.8 (1.6%), b_finish: 0.72 (0.4%), tests_pri_0: 125 (71.6%), check_dkim_signature: 0.51 (0.3%), check_dkim_adsp: 3.1 (1.8%), tests_pri_500: 4.0 (2.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH] kexec: Export kexec_in_progress to modules X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller writes: > From: Florian Fainelli > Date: Thu, 20 Oct 2016 18:15:16 -0700 > >> The bcm_sf2 driver uses kexec_in_progress to know whether it can power >> down an integrated PHY during shutdown, and can be built as a module. >> Other modules may be using this in the future, so export it. >> >> Fixes: 2399d6143f85 ("net: dsa: bcm_sf2: Prevent GPHY shutdown for kexec'd kernels") >> Signed-off-by: Florian Fainelli >> --- >> Eric, David, Stephen, >> >> The offending commit is in David's net.git tree, so it would probably make >> sense to route the fix through the same tree. > > Ok, I'll apply this, thanks Florian. Florian I am completely confused why any driver would want to do this. A reboot is semantically identical to a kexec restart. Always has been. That is pwoering down your hardware during reboot is not safe. The only thing that might save you is the hardware reset line being toggled at which point your hardware is powered up again anyway. So as far as I can tell you are advocating for a change to support a driver doing something that is completely pointless. So no let's not export this symbol. Please fix the driver to do something less pointless instead. Eric