From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLLF-0002fB-Bz
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:44:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLLA-0002nf-Cd
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:44:48 -0400
Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:35760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brLLA-0002n1-5u
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 04:44:44 -0400
Received: by mail-wm0-x22a.google.com with SMTP id f193so153658617wmg.0
	for <qemu-devel@nongnu.org>; Tue, 04 Oct 2016 01:44:43 -0700 (PDT)
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-4-git-send-email-rth@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1474048017-26696-4-git-send-email-rth@twiddle.net>
Date: Tue, 04 Oct 2016 09:44:41 +0100
Message-ID: <871szwtsee.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 03/35] exec: Avoid direct references to
 Int128 parts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org


Richard Henderson <rth@twiddle.net> writes:

> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  exec.c                |  4 ++--
>  include/qemu/int128.h | 10 ++++++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index c8389f9..cc2997e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -320,9 +320,9 @@ static inline bool section_covers_addr(const MemoryRegionSection *section,
>      /* Memory topology clips a memory region to [0, 2^64); size.hi > 0 means
>       * the section must cover the entire address space.
>       */
> -    return section->size.hi ||
> +    return int128_gethi(section->size) ||
>             range_covers_byte(section->offset_within_address_space,
> -                             section->size.lo, addr);
> +                             int128_getlo(section->size), addr);
>  }
>
>  static MemoryRegionSection *phys_page_find(PhysPageEntry lp, hwaddr addr,
> diff --git a/include/qemu/int128.h b/include/qemu/int128.h
> index c598881..52aaf99 100644
> --- a/include/qemu/int128.h
> +++ b/include/qemu/int128.h
> @@ -20,6 +20,16 @@ static inline uint64_t int128_get64(Int128 a)
>      return a.lo;
>  }
>
> +static inline uint64_t int128_getlo(Int128 a)
> +{
> +    return a.lo;
> +}
> +
> +static inline int64_t int128_gethi(Int128 a)
> +{
> +    return a.hi;
> +}
> +
>  static inline Int128 int128_zero(void)
>  {
>      return int128_make64(0);


--
Alex Bennée