From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40054)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIbXh-00062h-21
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:58:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIbXd-0000Tb-SN
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:58:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIbXd-0000TT-NP
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:58:01 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <20160413131513.31708.89296.stgit@bahia.huguette.org>
	<20160413131520.31708.12050.stgit@bahia.huguette.org>
Date: Thu, 30 Jun 2016 14:57:58 +0200
In-Reply-To: <20160413131520.31708.12050.stgit@bahia.huguette.org> (Greg
	Kurz's message of "Wed, 13 Apr 2016 15:15:20 +0200")
Message-ID: <871t3e96ll.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include <sys/uio.h>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Michael Fritscher <michael@fritscher.net>

Greg Kurz <gkurz@linux.vnet.ibm.com> writes:

> The <sys/uio.h> system header doesn't exist on all host platforms. Code should
> include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't
> define CONFIG_IOVEC (like win32, if it is to support 9p one day).
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
>  fsdev/9p-iov-marshal.c |    1 -
>  fsdev/9p-marshal.c     |    1 -
>  fsdev/file-op-9p.h     |    2 +-
>  3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
> index fb40bdf0d5f6..a564637b73c1 100644
> --- a/fsdev/9p-iov-marshal.c
> +++ b/fsdev/9p-iov-marshal.c
> @@ -15,7 +15,6 @@
>  #include <glib.h>
>  #include <glib/gprintf.h>
>  #include <utime.h>
> -#include <sys/uio.h>
>  
>  #include "9p-iov-marshal.h"
>  #include "qemu/bswap.h"
> diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c
> index 183d3667c681..df9d4f8e23c9 100644
> --- a/fsdev/9p-marshal.c
> +++ b/fsdev/9p-marshal.c
> @@ -16,7 +16,6 @@
>  #include <glib/gprintf.h>
>  #include <dirent.h>
>  #include <utime.h>
> -#include <sys/uio.h>
>  
>  #include "9p-marshal.h"
>  
> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
> index b8c26024a955..8736d1fa6d52 100644
> --- a/fsdev/file-op-9p.h
> +++ b/fsdev/file-op-9p.h
> @@ -12,9 +12,9 @@
>   */
>  #ifndef _FILEOP_H
>  #define _FILEOP_H
> +#include "qemu/osdep.h"

Every .c file must include qemu/osdep.h first.  You can and should rely
on that in headers.  Please drop this include.

>  #include <dirent.h>
>  #include <utime.h>
> -#include <sys/uio.h>
>  #include <sys/vfs.h>
>  
>  #define SM_LOCAL_MODE_BITS    0600