From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: David Woodhouse <dwmw2@infradead.org>, Vinod Koul <vinod.koul@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFC] DMA initialization for manually created devices
Date: Tue, 19 Apr 2016 15:52:06 +0300 [thread overview]
Message-ID: <871t61ep6x.fsf@intel.com> (raw)
In-Reply-To: <1461068047.3765.97.camel@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi,
David Woodhouse <dwmw2@infradead.org> writes:
> On Tue, 2016-04-19 at 14:38 +0300, Felipe Balbi wrote:
>>
>> The reason for that I'm using a manually created platform_device and
>> that misses dev->archdata which the underlying/parent PCI device has.
>
> Typically we'd expect you to use the parent device for DMA, as in your
> second option.
>
> That said, we're exploring the option of moving the dma_ops to be a
> first-class member of 'struct device' instead of hiding it in archdata,
> and cleaning up the way that it gets initialised for newly-created
> devices. And at that point we might end up letting it get inherited
> from the parent so your original code *would* work... but I wouldn't
> hold your breath for that.
>
> Definitely *don't* mess around in archdata.
alright, I'll patch it up to use parent device everywhere, at least for
now.
Thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-19 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 11:38 [RFC] DMA initialization for manually created devices Felipe Balbi
2016-04-19 12:14 ` David Woodhouse
2016-04-19 12:52 ` Felipe Balbi [this message]
2016-04-20 10:31 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t61ep6x.fsf@intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.