From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1as9dd-0006Hb-59
	for qemu-devel@nongnu.org; Mon, 18 Apr 2016 09:54:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1as9da-0007Wo-De
	for qemu-devel@nongnu.org; Mon, 18 Apr 2016 09:54:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42049)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1as9da-0007Wj-8b
	for qemu-devel@nongnu.org; Mon, 18 Apr 2016 09:54:50 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id C5B10C0293A7
	for <qemu-devel@nongnu.org>; Mon, 18 Apr 2016 13:54:49 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1460147350-7601-1-git-send-email-pbonzini@redhat.com>
	<1460147350-7601-40-git-send-email-pbonzini@redhat.com>
Date: Mon, 18 Apr 2016 15:54:47 +0200
In-Reply-To: <1460147350-7601-40-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Fri, 8 Apr 2016 22:28:59 +0200")
Message-ID: <871t63c994.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from
 gdbstub-xml.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> gdbstub-xml.c defines a bunch of arrays of strings; there is no
> need to include anything.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/feature_to_c.sh | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/scripts/feature_to_c.sh b/scripts/feature_to_c.sh
> index fb1f336..0994d95 100644
> --- a/scripts/feature_to_c.sh
> +++ b/scripts/feature_to_c.sh
> @@ -36,9 +36,6 @@ for input; do
>    arrayname=xml_feature_`echo $input | sed 's,.*/,,; s/[-.]/_/g'`
>  
>    ${AWK:-awk} 'BEGIN { n = 0
> -      printf "#include \"qemu/osdep.h\"\n"
> -      printf "#include \"qemu-common.h\"\n"
> -      printf "#include \"exec/gdbstub.h\"\n"
>        print "static const char '$arrayname'[] = {"
>        for (i = 0; i < 255; i++)
>          _ord_[sprintf("%c", i)] = i

We might want to include osdep.h anyway, just to avoid adding an
exception to the rule "any C file must include qemu/osdep.h first."