From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33139)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alcWZ-0003l3-8v
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:20:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alcWV-0003Vr-NS
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:20:35 -0400
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:38698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1alcWV-0003Vm-Az
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 09:20:31 -0400
Received: by mail-wm0-x22b.google.com with SMTP id 20so113644827wmh.1
	for <qemu-devel@nongnu.org>; Thu, 31 Mar 2016 06:20:31 -0700 (PDT)
References: <1458196505-5473-1-git-send-email-famz@redhat.com>
	<1458196505-5473-13-git-send-email-famz@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1458196505-5473-13-git-send-email-famz@redhat.com>
Date: Thu, 31 Mar 2016 14:20:33 +0100
Message-ID: <871t6qhjha.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 12/13] docker: Add EXTRA_CONFIGURE_OPTS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, jsnow@redhat.com, david@gibson.dropbear.id.au


Fam Zheng <famz@redhat.com> writes:

> Whatever passed in this variable will be appended to all
> configure commands.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/Makefile.include | 3 +++
>  tests/docker/common.rc        | 1 +
>  2 files changed, 4 insertions(+)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 033809a..4270a44 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -86,6 +86,8 @@ docker:
>  	@echo
>  	@echo 'Special variables:'
>  	@echo '    TARGET_LIST=a,b,c    Override target list in builds.'
> +	@echo '    EXTRA_CONFIGURE_OPTS="..."'
> +	@echo '                         Extra configure options.'
>  	@echo '    IMAGES="a b c ..":   Filters which images to build or run.'
>  	@echo '    TESTS="x y z .."     Filters which tests to run (for docker-test).'
>  	@echo '    J=[0..9]*            Overrides the -jN parameter for make commands'
> @@ -106,6 +108,7 @@ docker-run-%: docker-qemu-src
>  				--privileged -t \
>  				$(if $(DEBUG),-i,--net=none) \
>  				-e TARGET_LIST=$(TARGET_LIST) \
> +				-e EXTRA_CONFIGURE_OPTS=$(EXTRA_CONFIGURE_OPTS) \
>  				-e V=$V -e J=$J -e DEBUG=$(DEBUG)\
>  				-e CCACHE_DIR=/var/tmp/ccache \
>  				-v $$(realpath $(SRC_COPY)):/var/tmp/qemu:ro \
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 74b89d6..c493eeb 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -26,6 +26,7 @@ build_qemu()
>      $QEMU_SRC/configure \
>          --target-list="${TARGET_LIST}" \
>          --prefix="$PWD/install" \
> +        $EXTRA_CONFIGURE_OPTS \
>          "$@"
>      make $MAKEFLAGS
>  }


--
Alex Bennée