From: Nicolai Stange <nicstange@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Nicolai Stange <nicstange@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: user-mode-linux-user@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] um: asm/page.h: zero out a pte's high value in set_pte_val()
Date: Fri, 29 Jan 2016 00:56:48 +0100 [thread overview]
Message-ID: <871t91i7gf.fsf@gmail.com> (raw)
Commit 16da306849d0 ("um: kill pfn_t")
introduced a compile warning for defconfig:
arch/um/kernel/skas/mmu.c:38:206: warning: right shift count >= width of type
[-Wshift-count-overflow]
Aforementioned patch changes the definition of the phys_to_pfn() macro from
((pfn_t) ((p) >> PAGE_SHIFT))
to
((p) >> PAGE_SHIFT)
This effectively changes the phys_to_pfn() expansion's type from
unsigned long long to unsigned long.
Through the callchain init_stub_pte()->mk_pte(), the expansion of
phys_to_pfn() is (indirectly) fed into the 'phys' argument of the
pte_set_val(pte, phys, prot) macro, eventually leading to
(pte).pte_high = (phys) >> 32;
This results in the warning from above.
Since UML only deals with 32 bit addresses, the upper 32 bits from 'phys'
used to be zero anyway.
Zero out the pte value's high part in pte_set_val() in order to get rid
of the offending shift.
Fixes: 16da306849d0 ("um: kill pfn_t")
Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
arch/um/include/asm/page.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/include/asm/page.h b/arch/um/include/asm/page.h
index e13d41c..61e235f 100644
--- a/arch/um/include/asm/page.h
+++ b/arch/um/include/asm/page.h
@@ -46,8 +46,8 @@ typedef struct { unsigned long pgd; } pgd_t;
smp_wmb(); \
(to).pte_low = (from).pte_low; })
#define pte_is_zero(pte) (!((pte).pte_low & ~_PAGE_NEWPAGE) && !(pte).pte_high)
-#define pte_set_val(pte, phys, prot) \
- ({ (pte).pte_high = (phys) >> 32; \
+#define pte_set_val(pte, phys, prot) \
+ ({ (pte).pte_high = 0; \
(pte).pte_low = (phys) | pgprot_val(prot); })
#define pmd_val(x) ((x).pmd)
--
2.7.0
next reply other threads:[~2016-01-28 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 23:56 Nicolai Stange [this message]
2016-01-29 0:44 ` [PATCH] um: asm/page.h: zero out a pte's high value in set_pte_val() Richard Weinberger
2016-01-29 1:32 ` Nicolai Stange
2016-01-29 8:47 ` Richard Weinberger
2016-01-29 14:31 ` Nicolai Stange
2016-01-31 9:11 ` [uml-devel] " Richard Weinberger
2016-01-31 9:11 ` Richard Weinberger
2016-01-31 15:09 ` [PATCH v2] um: asm/page.h: remove the pte_high member from struct pte_t Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t91i7gf.fsf@gmail.com \
--to=nicstange@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.