From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0B61C1A170E for ; Mon, 21 Dec 2015 14:14:15 +1100 (AEDT) Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 20 Dec 2015 20:14:14 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 20 Dec 2015 20:14:11 -0700 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: stewart@linux.vnet.ibm.com X-IBM-RcptTo: openbmc@lists.ozlabs.org Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id E081219D8040 for ; Sun, 20 Dec 2015 20:02:14 -0700 (MST) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBL3EAgO24641778 for ; Sun, 20 Dec 2015 20:14:10 -0700 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBL3EATF016540 for ; Sun, 20 Dec 2015 20:14:10 -0700 Received: from birb.localdomain ([9.80.227.185]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tBL3E8V2016444; Sun, 20 Dec 2015 20:14:09 -0700 Received: by birb.localdomain (Postfix, from userid 1000) id 051982286E32; Mon, 21 Dec 2015 14:14:02 +1100 (AEDT) From: Stewart Smith To: Peng Fei BG Gou , Chris Austen Cc: openbmc , OpenBMC Patches Subject: Re: [PATCH phosphor-host-ipmid v3 2/6] Add get/set ipmid command support with correct DBUS property handling. In-Reply-To: References: <87twni5aqw.fsf@birb.au.ibm.com> User-Agent: Notmuch/0.21+24~gbceb651 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-redhat-linux-gnu) Date: Mon, 21 Dec 2015 14:14:02 +1100 Message-ID: <871tagmr2d.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15122103-0005-0000-0000-00001AC96E6C X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2015 03:14:16 -0000 Peng Fei BG Gou writes: > 2) there is a lot of deletes. Feels like this needs some additional eyes. > Yes, this pull request is too dirty and should be ignored. > Please refer to the new pull request which squashed unnecessary commits and > patched all together, as below: > https://github.com/openbmc/phosphor-host-ipmid/pull/55 Please fix your mail client to properly quote. Note that this is impossible with IBM Verse: go get a different mail client.