From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZzLGZ-0008Pf-Nx
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 04:12:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZzLGW-0001cc-Ga
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 04:12:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59298)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZzLGW-0001cW-BW
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 04:12:28 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id D7EAA8E220
	for <qemu-devel@nongnu.org>; Thu, 19 Nov 2015 09:12:27 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1447836791-369-29-git-send-email-eblake@redhat.com>
	<1447890426-16318-1-git-send-email-eblake@redhat.com>
	<87egfme57h.fsf@blackfin.pond.sub.org>
Date: Thu, 19 Nov 2015 10:12:25 +0100
In-Reply-To: <87egfme57h.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Thu, 19 Nov 2015 09:58:10 +0100")
Message-ID: <871tbmcpza.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] fixup? qapi: Simplify QObject
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
[...]
>> diff --git a/qobject/qobject.c b/qobject/qobject.c
>> new file mode 100644
>> index 0000000..db86571
>> --- /dev/null
>> +++ b/qobject/qobject.c
>> @@ -0,0 +1,26 @@
>> +/*
>> + * QObject
>> + *
>> + * Copyright (C) 2015 Red Hat, Inc.
>> + *
>> + * This work is licensed under the terms of the GNU LGPL, version 2.1
>> + * or later.  See the COPYING.LIB file in the top-level directory.
>> + */
>> +
>> +#include "qemu-common.h"
>> +#include "qapi/qmp/qbool.h"
>> +#include "qapi/qmp/qdict.h"
>> +#include "qapi/qmp/qfloat.h"
>> +#include "qapi/qmp/qint.h"
>> +#include "qapi/qmp/qlist.h"
>> +#include "qapi/qmp/qstring.h"
>> +
>> +QDestroy qdestroy[QTYPE_MAX] = {
>> +    [QTYPE_QBOOL] = qbool_destroy_obj,
>> +    [QTYPE_QDICT] = qdict_destroy_obj,
>> +    [QTYPE_QFLOAT] = qfloat_destroy_obj,
>> +    [QTYPE_QINT] = qint_destroy_obj,
>> +    [QTYPE_QLIST] = qlist_destroy_obj,
>> +    [QTYPE_QSTRING] = qstring_destroy_obj,
>> +    /* [QTYPE_QNULL] = NULL, */
>> +};
>
> Suggest
>
>    QDestroy qdestroy[QTYPE_MAX] = {
>        [QTYPE_QNULL] = NULL,       /* no such object exists */

QTYPE_NONE, of course.

>        [QTYPE_QNULL] = NULL,       /* qnull_ is indestructible */
>        ...
>    };

[...]