From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZWJCn-0004b8-KX
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:08:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZWJCj-0001Yu-KS
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:08:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44433)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZWJCj-0001Yo-Ev
	for qemu-devel@nongnu.org; Mon, 31 Aug 2015 03:08:33 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1440583182-5828-1-git-send-email-yanghy@cn.fujitsu.com>
	<1440583182-5828-4-git-send-email-yanghy@cn.fujitsu.com>
	<878u8ym649.fsf@blackfin.pond.sub.org> <55DDDD33.3000507@redhat.com>
	<87k2sfabku.fsf@blackfin.pond.sub.org>
	<55E3AFA2.1040702@cn.fujitsu.com>
Date: Mon, 31 Aug 2015 09:08:30 +0200
In-Reply-To: <55E3AFA2.1040702@cn.fujitsu.com> (Yang Hongyang's message of
	"Mon, 31 Aug 2015 09:36:34 +0800")
Message-ID: <871tek540h.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add
	netfilter_{add|del} commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, Luiz Capitulino <lcapitulino@redhat.com>, stefanha@redhat.com

Yang Hongyang <yanghy@cn.fujitsu.com> writes:

> On 08/28/2015 07:37 PM, Markus Armbruster wrote:
[...]
>> To make progress, I suggest you try the following:
>>
>> 1. Make NetFilter a flat union, as I suggested in my review of PATCH 2.
>>
>> 2. Use Eric's idea above, because it avoids the dependency on code
>>     that's still under review.
>>
>> Drawback: extra layer of nesting.  Ugly, but not the end of the world,
>> and we still have a chance to peel it off before the next release.
>
> Thanks for the explanation, I will try to see if I can fully understand
> your point.

If you have questions on the QAPI part, Eric and I will be happy to
answer them.