From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] gem_bad_blit: Make the BAD_GTT_TEST address more than 32 bits
Date: Fri, 15 May 2015 11:57:33 +0300 [thread overview]
Message-ID: <871tiinrpe.fsf@intel.com> (raw)
In-Reply-To: <1431614514-12665-1-git-send-email-damien.lespiau@intel.com>
On Thu, 14 May 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> gem_bad_blit.c: In function ‘bad_blit’:
> gem_bad_blit.c:89:3: warning: right shift count >= width of type [enabled by default]
> OUT_BATCH(BAD_GTT_DEST >> 32); /* Upper 16 bits */
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> tests/gem_bad_blit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_bad_blit.c b/tests/gem_bad_blit.c
> index 593167c..366b182 100644
> --- a/tests/gem_bad_blit.c
> +++ b/tests/gem_bad_blit.c
> @@ -60,7 +60,7 @@
> static drm_intel_bufmgr *bufmgr;
> struct intel_batchbuffer *batch;
>
> -#define BAD_GTT_DEST ((256*1024*1024)) /* past end of aperture */
> +#define BAD_GTT_DEST ((256*1024*1024ULL)) /* past end of aperture */
Why not three pairs of braces? Or... *gasp* just one? ;)
Jani.
>
> static void
> bad_blit(drm_intel_bo *src_bo, uint32_t devid)
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-15 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 14:41 [PATCH i-g-t] gem_bad_blit: Make the BAD_GTT_TEST address more than 32 bits Damien Lespiau
2015-05-15 8:57 ` Jani Nikula [this message]
2015-05-15 9:09 ` Chris Wilson
2015-05-18 8:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tiinrpe.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.