From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YfoIU-00085V-ND
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:37:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YfoIP-0002F8-LT
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:37:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36473)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YfoIP-0002F3-Dt
	for qemu-devel@nongnu.org; Wed, 08 Apr 2015 07:37:25 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1428474011-30797-13-git-send-email-liang.z.li@intel.com> (Liang
	Li's message of "Wed, 8 Apr 2015 14:20:09 +0800")
References: <1428474011-30797-1-git-send-email-liang.z.li@intel.com>
	<1428474011-30797-13-git-send-email-liang.z.li@intel.com>
Date: Wed, 08 Apr 2015 13:37:22 +0200
Message-ID: <871tjun959.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3
	parameters
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liang Li <liang.z.li@intel.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, Yang Zhang <yang.z.zhang@intel.com>, amit.shah@redhat.com, dgilbert@redhat.com

Liang Li <liang.z.li@intel.com> wrote:
> Put the three parameters related to multiple thread (de)compression
> into an int array, and use an enum type to index the parameter.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>


BTW, for the libvirt people, what do you think about moving the other
parameters here, and make the other accessors deprecated?

I mean here:
- xbzrle_cache_size
-> get mbps
-> set/get migration_speed
-> get/set migration_downtime
-> autoconverge?

You get the idea.

Later, Juan.