From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbReC-0002ji-F4 for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:37:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbRe6-0000vZ-F3 for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:37:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbRe6-0000vQ-88 for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:37:46 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-28-git-send-email-eblake@redhat.com> Date: Fri, 27 Mar 2015 11:37:43 +0100 In-Reply-To: <1427227433-5030-28-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 24 Mar 2015 14:03:52 -0600") Message-ID: <871tkapvyg.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. > This patch fixes one of only two commands relying on nested > types, by breaking the nesting into an explicit type; it means > that the type is now boxed instead of unboxed in C code, but the > QMP wire format is unaffected by this change. > > Prefer the safer g_new0() while making the conversion, and reduce > some long lines. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster