From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YY8WG-00058n-8i
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 03:36:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YY8WC-0004TQ-IC
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 03:36:00 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1426643370-15804-1-git-send-email-arei.gonglei@huawei.com>
	<1426643370-15804-2-git-send-email-arei.gonglei@huawei.com>
	<1426662159.32192.4.camel@nilsson.home.kraxel.org>
Date: Wed, 18 Mar 2015 08:35:49 +0100
In-Reply-To: <1426662159.32192.4.camel@nilsson.home.kraxel.org> (Gerd
	Hoffmann's message of "Wed, 18 Mar 2015 08:02:39 +0100")
Message-ID: <871tkmiwq2.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when
	hot-unplugging uhci controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: peter.huangpeng@huawei.com, arei.gonglei@huawei.com, qemu-stable <qemu-stable@nongnu.org>, qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>> -static void uhci_reset(void *opaque)
>> +static void uhci_reset(DeviceState *dev)
>>  {
>> -    UHCIState *s = opaque;
>> +    PCIDevice *d = PCI_DEVICE(dev);
>> +    UHCIState *s = DO_UPCAST(UHCIState, dev, d);
>
> Uh, oh, DO_UPCAST() is long deprecated.  There are other instances of
[...]

Only 378 instances left in the code %-}