From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 13/21] ARM: omap: convert wakeupgen to stacked domains Date: Thu, 15 Jan 2015 14:28:53 +0000 Message-ID: <871tmwi0d6.fsf@approximate.cambridge.arm.com> References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-14-git-send-email-marc.zyngier@arm.com> <20150114222814.GU2419@atomide.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20150114222814.GU2419@atomide.com> (Tony Lindgren's message of "Wed, 14 Jan 2015 22:28:14 +0000") Sender: linux-samsung-soc-owner@vger.kernel.org To: Tony Lindgren Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Benoit Cousson , Nishanth Menon , Santosh Shilimkar , Shawn Guo , Sascha Hauer , Kukjin Kim , Simon Horman , Magnus Damm , Linus Walleij , Michal Simek , Rob Herring , Mark Rutland , Jason Cooper , Thomas Gleixner , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-omap@vger.kernel.org" List-Id: linux-omap@vger.kernel.org On Wed, Jan 14 2015 at 10:28:14 pm GMT, Tony Lindgren wrote: > * Marc Zyngier [150112 10:30]: >> OMAP4/5 has been (ab)using the gic_arch_extn to provide >> wakeup from suspend, and it makes a lot of sense to convert >> this code to use stacked domains instead. >> >> This patch does just this, updating the DT files to actually >> reflect what the HW provides. >> >> BIG FAT WARNING: because the DTs were so far lying by not >> exposing the WUGEN HW block, kernels with this patch applied >> won't have any suspend-resume facility when booted with old DTs, >> and old kernels with updated DTs won't even boot. >> >> On a platform with this patch applied, the system looks like >> this: >> >> root@bacon-fat:~# cat /proc/interrupts >> CPU0 CPU1 >> 16: 0 0 WUGEN 37 gp_timer >> 19: 233799 155916 GIC 27 arch_timer >> 23: 0 0 WUGEN 9 l3-dbg-irq >> 24: 1 0 WUGEN 10 l3-app-irq >> 27: 282 0 WUGEN 13 omap-dma-engine >> 44: 0 0 4ae10000.gpio 13 DMA > > FYI, the legacy irq numbers are now all wrong since commit > 9a1091ef0017 ("irqchip: gic: Support hierarchy irq domain."). > > Started a separate thread "Regression with legacy IRQ numbers > caused by 9a1091ef0017" on it, will give these a try once > that's sorted out. Assuming the workaround I posted earlier works, the OMAP/DRA7 part of this series is going to require some rework too (I need to know where these legacy interrupts are attached: crossbar, WUGEN, or GIC?). Thanks, M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 15 Jan 2015 14:28:53 +0000 Subject: [PATCH v3 13/21] ARM: omap: convert wakeupgen to stacked domains In-Reply-To: <20150114222814.GU2419@atomide.com> (Tony Lindgren's message of "Wed, 14 Jan 2015 22:28:14 +0000") References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-14-git-send-email-marc.zyngier@arm.com> <20150114222814.GU2419@atomide.com> Message-ID: <871tmwi0d6.fsf@approximate.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 14 2015 at 10:28:14 pm GMT, Tony Lindgren wrote: > * Marc Zyngier [150112 10:30]: >> OMAP4/5 has been (ab)using the gic_arch_extn to provide >> wakeup from suspend, and it makes a lot of sense to convert >> this code to use stacked domains instead. >> >> This patch does just this, updating the DT files to actually >> reflect what the HW provides. >> >> BIG FAT WARNING: because the DTs were so far lying by not >> exposing the WUGEN HW block, kernels with this patch applied >> won't have any suspend-resume facility when booted with old DTs, >> and old kernels with updated DTs won't even boot. >> >> On a platform with this patch applied, the system looks like >> this: >> >> root at bacon-fat:~# cat /proc/interrupts >> CPU0 CPU1 >> 16: 0 0 WUGEN 37 gp_timer >> 19: 233799 155916 GIC 27 arch_timer >> 23: 0 0 WUGEN 9 l3-dbg-irq >> 24: 1 0 WUGEN 10 l3-app-irq >> 27: 282 0 WUGEN 13 omap-dma-engine >> 44: 0 0 4ae10000.gpio 13 DMA > > FYI, the legacy irq numbers are now all wrong since commit > 9a1091ef0017 ("irqchip: gic: Support hierarchy irq domain."). > > Started a separate thread "Regression with legacy IRQ numbers > caused by 9a1091ef0017" on it, will give these a try once > that's sorted out. Assuming the workaround I posted earlier works, the OMAP/DRA7 part of this series is going to require some rework too (I need to know where these legacy interrupts are attached: crossbar, WUGEN, or GIC?). Thanks, M. -- Jazz is not dead. It just smells funny.