From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW5ba-0004TR-5x
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:32:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW5bU-0007W8-Tc
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:32:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW5bU-0007VJ-LB
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 11:32:40 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1411310339-27733-1-git-send-email-alex@alex.org.uk>
	<1411310339-27733-3-git-send-email-alex@alex.org.uk>
	<20140922113655.GI14882@redhat.com>
Date: Mon, 22 Sep 2014 17:32:16 +0200
In-Reply-To: <20140922113655.GI14882@redhat.com> (Michael S. Tsirkin's message
	of "Mon, 22 Sep 2014 14:36:55 +0300")
Message-ID: <871tr37jsv.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 2/2] Add configure option
	--enable-pc-1-0-qemu-kvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ryan Harper <ryan.harper@canonical.com>, Serge Hallyn <serge.hallyn@canonical.com>, "quintela@redhat.com" <quintela@redhat.com>, Libvirt <libvir-list@redhat.com>, Serge Hallyn <serge.hallyn@ubuntu.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Alex Bligh <alex@alex.org.uk>, Cole Robinson <crobinso@redhat.com>, Amit Shah <amit.shah@redhat.com>, Bruce Rogers <brogers@suse.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, "Serge E. Hallyn" <serge@hallyn.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
>> Add a configure option --enable-pc-1-0-qemu-kvm and the
>> corresponding --disable-pc-1-0-qemu-kvm, defaulting
>> to disabled.
>> 
>> Rename machine type pc-1.0 to pc-1.0-qemu-git.
>> 
>> Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
>> or pc-1.0-qemu-git depending on the value of the config
>> option.
>> 
>> Signed-off-by: Alex Bligh <alex@alex.org.uk>
>
> I have to say, this one bothers me.
> We end up not being able to predict what does pc-1.0
> reference.
>
> Users also don't get qemu from git so I don't see
> why does git make sense in the name?
>
> Legacy management applications invoked qemu as qemu-kvm -
> how about detecting that name and switching
> the machine types?

Ugh!  I like that even less than a configure option.

> It might make sense to also set -enable-kvm and
> change default CPU to kvm64 in this case.

Yup.