From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Don Zickus <dzickus@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 5/5] perf tools: Share process map groups within process threads
Date: Mon, 17 Mar 2014 16:25:15 +0900 [thread overview]
Message-ID: <871ty1thgk.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1394805606-25883-6-git-send-email-jolsa@redhat.com> (Jiri Olsa's message of "Fri, 14 Mar 2014 15:00:06 +0100")
On Fri, 14 Mar 2014 15:00:06 +0100, Jiri Olsa wrote:
> + if (!mg) {
> + struct thread *leader = thread__get_leader(thread);
> +
> + if (!leader)
> + return NULL;
> +
> + if (leader->mg)
> + mg = leader->mg;
> + else
> + mg = thread__map_groups_alloc(leader);
> +
> + if (leader != thread)
> + thread->mg = mg;
> +
> + mg->refcnt++;
What's the value of mg->refcnt here in case of leader != thread and
leader->mg was not allocated originally? I think it's 1 - but shouldn't
it be 2 since it's referenced from both of leader and the thread now?
Thanks,
Namhyung
next prev parent reply other threads:[~2014-03-17 7:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 14:00 [RFC 0/5] perf tools: Share map groups within process Jiri Olsa
2014-03-14 14:00 ` [PATCH 1/5] perf tests: Add tip/pid mmap automated tests Jiri Olsa
2014-03-14 20:24 ` Arnaldo Carvalho de Melo
2014-03-17 6:57 ` Jiri Olsa
2014-03-17 4:50 ` Namhyung Kim
2014-03-17 10:39 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 2/5] perf tools: Factor machine__find_thread to take tid argument Jiri Olsa
2014-03-14 14:15 ` Arnaldo Carvalho de Melo
2014-03-14 15:40 ` Adrian Hunter
2014-03-18 8:31 ` [tip:perf/core] perf machine: " tip-bot for Jiri Olsa
2014-03-14 14:00 ` [PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly Jiri Olsa
2014-03-14 14:13 ` Arnaldo Carvalho de Melo
2014-03-17 7:13 ` Namhyung Kim
2014-03-17 14:52 ` Jiri Olsa
[not found] ` <87lhw8rnsi.fsf@sejong.aot.lge.com>
2014-03-18 13:31 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 4/5] perf tools: Add machine pointer into thread struct Jiri Olsa
2014-03-14 14:16 ` Arnaldo Carvalho de Melo
2014-03-17 7:17 ` Namhyung Kim
2014-03-17 14:56 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 5/5] perf tools: Share process map groups within process threads Jiri Olsa
2014-03-14 14:18 ` Arnaldo Carvalho de Melo
2014-03-17 7:25 ` Namhyung Kim [this message]
2014-03-17 10:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ty1thgk.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.