From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: [PATCH] vfs: Don't leak a path when get_empty_filp in dentry_open Date: Thu, 16 Jan 2014 15:45:38 -0800 Message-ID: <871u07wkwt.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Andrew Morton , To: Al Viro Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Normally in dentry_open the passed in path is placed on the new filp removing the caller from needing to worry about it. In the rare case that we can not allocate a filp the path is not consumed. None of the callers of dentry_open call path_put in their error handling when dentry_open fails so call path_put for them on error and keep everyone's error handling simple. Cc: stable@vger.kernel.org Signed-off-by: "Eric W. Biederman" --- fs/open.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/open.c b/fs/open.c index 4b3e1edf2fe4..0afa243941da 100644 --- a/fs/open.c +++ b/fs/open.c @@ -843,6 +843,8 @@ struct file *dentry_open(const struct path *path, int flags, put_filp(f); f = ERR_PTR(error); } + } else { + path_put(path); } return f; } -- 1.7.5.4