All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <tr@thomasrast.ch>
To: Max Kirillov <max@max630.net>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: make pointer selection visible in highlighted lines
Date: Wed, 27 Nov 2013 20:16:13 +0100	[thread overview]
Message-ID: <871u21hczm.fsf@thomasrast.ch> (raw)
In-Reply-To: <20131127180601.GA31211@wheezy.local> (Max Kirillov's message of "Wed, 27 Nov 2013 20:06:01 +0200")

Max Kirillov <max@max630.net> writes:

> Custom tags have higher priority than sel, and when they define
> their own background, it makes selection invisible. Especially
> inconvenient for filesep (to select filenames), but may aslo affect
> other tags.
>
> Signed-off-by: Max Kirillov <max@max630.net>

Nice.

Tested-by: Thomas Rast <tr@thomasrast.ch>

> ---
>  gitk-git/gitk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 5cd00d8..9f350ab 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2385,6 +2385,7 @@ proc makewindow {} {
>      $ctext tag conf found -back $foundbgcolor
>      $ctext tag conf currentsearchhit -back $currentsearchhitbgcolor
>      $ctext tag conf wwrap -wrap word
> +    $ctext tag raise sel
>  
>      .pwbottom add .bleft
>      if {!$use_ttk} {

-- 
Thomas Rast
tr@thomasrast.ch

  reply	other threads:[~2013-11-27 19:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 18:06 [PATCH] gitk: make pointer selection visible in highlighted lines Max Kirillov
2013-11-27 19:16 ` Thomas Rast [this message]
2013-11-27 20:29 ` Eric Sunshine
2013-11-28 21:20 ` [PATCH v2] " Max Kirillov
2013-12-01 22:41   ` Paul Mackerras
2013-12-02 10:04     ` Stefan Haller
2013-12-03  0:35       ` Max Kirillov
2013-12-11 23:36       ` [RFC] HACK: use anchor mark instead of sel tag Max Kirillov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u21hczm.fsf@thomasrast.ch \
    --to=tr@thomasrast.ch \
    --cc=git@vger.kernel.org \
    --cc=max@max630.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.