All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 6/6] perf util: Change trace info output file name
Date: Thu, 14 Mar 2013 17:23:08 +0900	[thread overview]
Message-ID: <871ubil79v.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <51408364.8050104@gmail.com> (David Ahern's message of "Wed, 13 Mar 2013 07:47:16 -0600")

Hi David,

On Wed, 13 Mar 2013 07:47:16 -0600, David Ahern wrote:
> On 3/13/13 5:19 AM, Namhyung Kim wrote:
>> -static const char *output_file = "trace.info";
>> +static const char *output_file = "perf.data";
>>   static int output_fd;
>
> Not really needed. Only use is a couple of die() calls. Since the file
> name is not used on the open the die message would be misleading.

I know.  But it just looked too ugly to me. :)

I'm fine with dropping this one.  I think I'm going to get rid of these
die() and something_or_die() calls soonish..

Thanks,
Namhyung

      reply	other threads:[~2013-03-14  8:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 11:19 [PATCH 0/6] perf util: Cleanup trace related files Namhyung Kim
2013-03-13 11:19 ` [PATCH 1/6] perf util: Remove unused trace_read_data function Namhyung Kim
2013-03-21 11:32   ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 2/6] perf util: Remove unused struct definitions Namhyung Kim
2013-03-21 11:33   ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 3/6] perf util: Remove unnecessary calc_data_size variable Namhyung Kim
2013-03-21 11:34   ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 4/6] perf util: Remove unused macro definitions Namhyung Kim
2013-03-21 11:35   ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 5/6] perf util: Remove duplicated page_size definition Namhyung Kim
2013-03-21 11:37   ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 6/6] perf util: Change trace info output file name Namhyung Kim
2013-03-13 13:47   ` David Ahern
2013-03-14  8:23     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ubil79v.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.