From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal Date: Tue, 11 Dec 2012 09:39:41 +1030 Message-ID: <871uexec7e.fsf@rustcorp.com.au> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> <87ip96id3a.fsf@rustcorp.com.au> <20121210055401.GA17187@amit.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20121210055401.GA17187@amit.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: "Michael S. Tsirkin" , sjur@brendeland.net, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, masami.hiramatsu.pt@hitachi.com, Sjur =?utf-8?Q?Br=C3=A6ndeland?= List-Id: virtualization@lists.linuxfoundation.org QW1pdCBTaGFoIDxhbWl0LnNoYWhAcmVkaGF0LmNvbT4gd3JpdGVzOgoKPiBPbiAoRnJpKSAxNiBO b3YgMjAxMiBbMTE6MjI6MDldLCBSdXN0eSBSdXNzZWxsIHdyb3RlOgo+PiBBbWl0IFNoYWggPGFt aXQuc2hhaEByZWRoYXQuY29tPiB3cml0ZXM6Cj4+ID4gRnJvbTogU2p1ciBCcsOmbmRlbGFuZCA8 c2p1ci5icmFuZGVsYW5kQHN0ZXJpY3Nzb24uY29tPgo+PiA+Cj4+ID4gUmVtb3ZlIGJ1ZmZlcnMg ZnJvbSB0aGUgb3V0LXF1ZXVlIHdoZW4gYSBwb3J0IGlzIHJlbW92ZWQuIFJwcm9jX3NlcmlhbAo+ PiA+IGNvbW11bmljYXRlcyB3aXRoIHJlbW90ZSBwcm9jZXNzb3JzIHRoYXQgbWF5IGNyYXNoIGFu ZCBsZWF2ZSBidWZmZXJzIGluCj4+ID4gdGhlIG91dC1xdWV1ZS4gVGhlIHZpcnRpbyBzZXJpYWwg cG9ydHMgbWF5IGhhdmUgYnVmZmVycyBpbiB0aGUgb3V0LXF1ZXVlCj4+ID4gYXMgd2VsbCwgZS5n LiBmb3Igbm9uLWJsb2NraW5nIHBvcnRzIGFuZCB0aGUgaG9zdCBkaWRuJ3QgY29uc3VtZSB0aGVt Cj4+ID4geWV0Lgo+PiA+Cj4+ID4gW0FtaXQ6IFJlbW92ZSBXQVJOX09OIGZvciBnZW5lcmljIHBv cnRzIGNhc2UuXQo+PiA+Cj4+ID4gU2lnbmVkLW9mZi1ieTogU2p1ciBCcsOmbmRlbGFuZCA8c2p1 ci5icmFuZGVsYW5kQHN0ZXJpY3Nzb24uY29tPgo+PiA+IFNpZ25lZC1vZmYtYnk6IEFtaXQgU2hh aCA8YW1pdC5zaGFoQHJlZGhhdC5jb20+Cj4+IAo+PiBJIGFscmVhZHkgaGF2ZSB0aGlzIGluIG15 IHBlbmRpbmcgcXVldWU7IEkndmUgcHJvbW90ZWQgaXQgdG8gbXkKPj4gdmlydGlvLW5leHQgYnJh bmNoIG5vdy4KPgo+IFJ1c3R5LCBJIHN0aWxsIHNlZSB0aGlzIHNlcmllcyBpbiB5b3VyIHBlbmRp bmcgcXVldWUsIG5vdCBpbgo+IHZpcnRpby1uZXh0LiAgRGlkIGFueXRoaW5nIGNoYW5nZSBpbiB0 aGUgbWVhbnRpbWU/Cj4KPiAJCUFtaXQKCkhtbToKCjQwZTYyNWFjNTBmNDBkODdkZGJhOTMyODBk MGE1MDM0MjVhYTY4ZTk/CgpDaGVlcnMsClJ1c3R5LgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVh bGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZv dW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259Ab2LJX6v (ORCPT ); Mon, 10 Dec 2012 18:58:51 -0500 Received: from ozlabs.org ([203.10.76.45]:41125 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289Ab2LJX6r convert rfc822-to-8bit (ORCPT ); Mon, 10 Dec 2012 18:58:47 -0500 From: Rusty Russell To: Amit Shah Cc: sjur@brendeland.net, "Michael S. Tsirkin" , linus.walleij@linaro.org, masami.hiramatsu.pt@hitachi.com, ohad@wizery.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Sjur =?utf-8?Q?Br=C3=A6ndeland?= Subject: Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal In-Reply-To: <20121210055401.GA17187@amit.redhat.com> References: <029d7029bc1186fbd2ec74123dc88922b9600660.1352366215.git.amit.shah@redhat.com> <87ip96id3a.fsf@rustcorp.com.au> <20121210055401.GA17187@amit.redhat.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Tue, 11 Dec 2012 09:39:41 +1030 Message-ID: <871uexec7e.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Amit Shah writes: > On (Fri) 16 Nov 2012 [11:22:09], Rusty Russell wrote: >> Amit Shah writes: >> > From: Sjur Brændeland >> > >> > Remove buffers from the out-queue when a port is removed. Rproc_serial >> > communicates with remote processors that may crash and leave buffers in >> > the out-queue. The virtio serial ports may have buffers in the out-queue >> > as well, e.g. for non-blocking ports and the host didn't consume them >> > yet. >> > >> > [Amit: Remove WARN_ON for generic ports case.] >> > >> > Signed-off-by: Sjur Brændeland >> > Signed-off-by: Amit Shah >> >> I already have this in my pending queue; I've promoted it to my >> virtio-next branch now. > > Rusty, I still see this series in your pending queue, not in > virtio-next. Did anything change in the meantime? > > Amit Hmm: 40e625ac50f40d87ddba93280d0a503425aa68e9? Cheers, Rusty.