From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJlwV-00042Z-Q0 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:58:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJlwP-0006SE-Tu for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:58:23 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:50673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJlwP-0006Rk-OX for qemu-devel@nongnu.org; Thu, 04 Oct 2012 09:58:17 -0400 Received: by mail-ob0-f173.google.com with SMTP id wc18so449717obb.4 for ; Thu, 04 Oct 2012 06:58:16 -0700 (PDT) From: Anthony Liguori In-Reply-To: <1349280245-16341-2-git-send-email-avi@redhat.com> References: <1349280245-16341-1-git-send-email-avi@redhat.com> <1349280245-16341-2-git-send-email-avi@redhat.com> Date: Thu, 04 Oct 2012 08:58:13 -0500 Message-ID: <871uhejq4q.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [RFC v1 01/22] memory: rename 'exec-obsolete.h' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , qemu-devel@nongnu.org, liu ping fan , "Michael S. Tsirkin" , Paolo Bonzini , Blue Swirl Avi Kivity writes: > exec-obsolete.h used to hold pre-memory-API functions that were used from > device code prior to the transition to the memory API. Now that the > transition is complete, the name no longer describes the file. The > functions still need to be merged better into the memory core, but there's > no danger of anyone using them. > > Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > cputlb.c | 3 +-- > exec.c | 3 +-- > exec-obsolete.h => memory-internal.h | 8 ++------ > memory.c | 3 +-- > 4 files changed, 5 insertions(+), 12 deletions(-) > rename exec-obsolete.h => memory-internal.h (97%) > > diff --git a/cputlb.c b/cputlb.c > index 51b5897..0627f32 100644 > --- a/cputlb.c > +++ b/cputlb.c > @@ -24,8 +24,7 @@ > > #include "cputlb.h" > > -#define WANT_EXEC_OBSOLETE > -#include "exec-obsolete.h" > +#include "memory-internal.h" > > //#define DEBUG_TLB > //#define DEBUG_TLB_CHECK > diff --git a/exec.c b/exec.c > index bb6aa4a..5c703b9 100644 > --- a/exec.c > +++ b/exec.c > @@ -59,8 +59,7 @@ > > #include "cputlb.h" > > -#define WANT_EXEC_OBSOLETE > -#include "exec-obsolete.h" > +#include "memory-internal.h" > > //#define DEBUG_TB_INVALIDATE > //#define DEBUG_FLUSH > diff --git a/exec-obsolete.h b/memory-internal.h > similarity index 97% > rename from exec-obsolete.h > rename to memory-internal.h > index c099256..655f71f 100644 > --- a/exec-obsolete.h > +++ b/memory-internal.h > @@ -16,12 +16,8 @@ > * The functions declared here will be removed soon. > */ > > -#ifndef EXEC_OBSOLETE_H > -#define EXEC_OBSOLETE_H > - > -#ifndef WANT_EXEC_OBSOLETE > -#error Do not include exec-obsolete.h > -#endif > +#ifndef MEMORY_INTERNAL_H > +#define MEMORY_INTERNAL_H > > #ifndef CONFIG_USER_ONLY > > diff --git a/memory.c b/memory.c > index 4f3ade0..1aeca08 100644 > --- a/memory.c > +++ b/memory.c > @@ -20,8 +20,7 @@ > #include "kvm.h" > #include > > -#define WANT_EXEC_OBSOLETE > -#include "exec-obsolete.h" > +#include "memory-internal.h" > > unsigned memory_region_transaction_depth = 0; > static bool global_dirty_log = false; > -- > 1.7.12