From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzlCO-0003I5-Bb for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:08:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzlCI-0001DC-0O for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:08:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzlCH-0001D4-Oi for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:07:57 -0400 From: Markus Armbruster References: <1344354826-10375-1-git-send-email-lcapitulino@redhat.com> <1344354826-10375-15-git-send-email-lcapitulino@redhat.com> Date: Fri, 10 Aug 2012 11:07:53 +0200 In-Reply-To: <1344354826-10375-15-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Tue, 7 Aug 2012 12:53:25 -0300") Message-ID: <871ujfcdxy.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 14/35] net: inet_connect(), inet_connect_opts(): add in_progress argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com Luiz Capitulino writes: > It's used to indicate the special case where a valid file-descriptor > is returned (ie. success) but the connection can't be completed > w/o blocking. Why callers need that isn't obvious from this patch. It's used in PATCH 16. Either squash the two to make it obvious, or furher explain the purpose in this commit message. I'd recommend the former.