From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/3] ARM: OMAP: omap_device: keep track of driver bound status Date: Tue, 07 Aug 2012 14:49:57 -0700 Message-ID: <871uji1iey.fsf@ti.com> References: <1341961324-19657-1-git-send-email-khilman@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:34426 "EHLO na3sys009aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755927Ab2HGVt5 (ORCPT ); Tue, 7 Aug 2012 17:49:57 -0400 Received: by pbbrp16 with SMTP id rp16so256286pbb.10 for ; Tue, 07 Aug 2012 14:49:56 -0700 (PDT) In-Reply-To: (Paul Walmsley's message of "Tue, 7 Aug 2012 15:26:00 -0600 (MDT)") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Paul Walmsley writes: > Hi Kevin > > a couple of minor comments > > On Tue, 10 Jul 2012, Kevin Hilman wrote: > >> Use the bus notifier to keep track of driver bound status by adding a >> new internal field to struct omap_device: _driver_staus. > > "_driver_status" > >> This will be useful for follow-up patches which need to know whether >> or not a driver is bound in order to make intelligent omap_device >> enable/idle decisions. >> >> Cc: Paul Walmsley >> Signed-off-by: Kevin Hilman >> --- >> arch/arm/plat-omap/include/plat/omap_device.h | 2 ++ >> arch/arm/plat-omap/omap_device.c | 14 +++++++++----- >> 2 files changed, 11 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/plat-omap/include/plat/omap_device.h b/arch/arm/plat-omap/include/plat/omap_device.h >> index 4327b2c..e0486cb 100644 >> --- a/arch/arm/plat-omap/include/plat/omap_device.h >> +++ b/arch/arm/plat-omap/include/plat/omap_device.h >> @@ -60,6 +60,7 @@ extern struct dev_pm_domain omap_device_pm_domain; >> * @_dev_wakeup_lat_limit: dev wakeup latency limit in nsec - set by OMAP PM >> * @_state: one of OMAP_DEVICE_STATE_* (see above) >> * @flags: device flags >> + * @_driver_status: one of BUS_NOTIFY_*_DRIVER from >> * >> * Integrates omap_hwmod data into Linux platform_device. >> * >> @@ -78,6 +79,7 @@ struct omap_device { >> u8 hwmods_cnt; >> u8 _state; >> u8 flags; >> + u8 _driver_status; >> }; >> >> /* Device driver interface (call via platform_data fn ptrs) */ >> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c >> index c490240..1d1b5ff 100644 >> --- a/arch/arm/plat-omap/omap_device.c >> +++ b/arch/arm/plat-omap/omap_device.c >> @@ -385,17 +385,21 @@ static int _omap_device_notifier_call(struct notifier_block *nb, >> unsigned long event, void *dev) >> { >> struct platform_device *pdev = to_platform_device(dev); >> + struct omap_device *od; >> >> switch (event) { >> - case BUS_NOTIFY_ADD_DEVICE: >> - if (pdev->dev.of_node) >> - omap_device_build_from_dt(pdev); >> - break; >> - >> case BUS_NOTIFY_DEL_DEVICE: >> if (pdev->archdata.od) >> omap_device_delete(pdev->archdata.od); >> break; >> + case BUS_NOTIFY_ADD_DEVICE: >> + if (pdev->dev.of_node) >> + omap_device_build_from_dt(pdev); >> + /* fall through */ >> + default: >> + od = to_omap_device(pdev); >> + if (od) >> + od->_driver_status = event; > > _driver_status is a u8, but event is an unsigned long. Might be worth > adding a WARN() to complain if event is greater than (2^8)-1. > It's probably more future proof if I just make _driver_status an unsigned long, in case the values of those events ever change in the driver core. Thanks for the review, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Tue, 07 Aug 2012 14:49:57 -0700 Subject: [PATCH 1/3] ARM: OMAP: omap_device: keep track of driver bound status In-Reply-To: (Paul Walmsley's message of "Tue, 7 Aug 2012 15:26:00 -0600 (MDT)") References: <1341961324-19657-1-git-send-email-khilman@ti.com> Message-ID: <871uji1iey.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul Walmsley writes: > Hi Kevin > > a couple of minor comments > > On Tue, 10 Jul 2012, Kevin Hilman wrote: > >> Use the bus notifier to keep track of driver bound status by adding a >> new internal field to struct omap_device: _driver_staus. > > "_driver_status" > >> This will be useful for follow-up patches which need to know whether >> or not a driver is bound in order to make intelligent omap_device >> enable/idle decisions. >> >> Cc: Paul Walmsley >> Signed-off-by: Kevin Hilman >> --- >> arch/arm/plat-omap/include/plat/omap_device.h | 2 ++ >> arch/arm/plat-omap/omap_device.c | 14 +++++++++----- >> 2 files changed, 11 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/plat-omap/include/plat/omap_device.h b/arch/arm/plat-omap/include/plat/omap_device.h >> index 4327b2c..e0486cb 100644 >> --- a/arch/arm/plat-omap/include/plat/omap_device.h >> +++ b/arch/arm/plat-omap/include/plat/omap_device.h >> @@ -60,6 +60,7 @@ extern struct dev_pm_domain omap_device_pm_domain; >> * @_dev_wakeup_lat_limit: dev wakeup latency limit in nsec - set by OMAP PM >> * @_state: one of OMAP_DEVICE_STATE_* (see above) >> * @flags: device flags >> + * @_driver_status: one of BUS_NOTIFY_*_DRIVER from >> * >> * Integrates omap_hwmod data into Linux platform_device. >> * >> @@ -78,6 +79,7 @@ struct omap_device { >> u8 hwmods_cnt; >> u8 _state; >> u8 flags; >> + u8 _driver_status; >> }; >> >> /* Device driver interface (call via platform_data fn ptrs) */ >> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c >> index c490240..1d1b5ff 100644 >> --- a/arch/arm/plat-omap/omap_device.c >> +++ b/arch/arm/plat-omap/omap_device.c >> @@ -385,17 +385,21 @@ static int _omap_device_notifier_call(struct notifier_block *nb, >> unsigned long event, void *dev) >> { >> struct platform_device *pdev = to_platform_device(dev); >> + struct omap_device *od; >> >> switch (event) { >> - case BUS_NOTIFY_ADD_DEVICE: >> - if (pdev->dev.of_node) >> - omap_device_build_from_dt(pdev); >> - break; >> - >> case BUS_NOTIFY_DEL_DEVICE: >> if (pdev->archdata.od) >> omap_device_delete(pdev->archdata.od); >> break; >> + case BUS_NOTIFY_ADD_DEVICE: >> + if (pdev->dev.of_node) >> + omap_device_build_from_dt(pdev); >> + /* fall through */ >> + default: >> + od = to_omap_device(pdev); >> + if (od) >> + od->_driver_status = event; > > _driver_status is a u8, but event is an unsigned long. Might be worth > adding a WARN() to complain if event is greater than (2^8)-1. > It's probably more future proof if I just make _driver_status an unsigned long, in case the values of those events ever change in the driver core. Thanks for the review, Kevin