From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: virtio config access races
Date: Fri, 13 Jul 2012 13:25:15 +0930 [thread overview]
Message-ID: <871ukgz55o.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120712225941.GA9317@redhat.com>
On Fri, 13 Jul 2012 01:59:41 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> It looks like there's a problem in the way virtio config currently
> works: if driver reads config in probe routine, config
> subsequently can change before core sets DRIVER_OK.
> This will not cause an interrupt and so this event is lost.
> Maybe we should document that devices should delay such
> events until after DRIVER_OK?
The device is currently defined to be active from the time we
acknowledge the features (which means we may get a spurious interrupt
before we probe, I think). We abuse this for virtio_blk for example,
where we add_disk() inside the probe function.
Hmm, the changed interrupt is live from find_vqs, right? Perhaps we
should leave it to drivers to set that up in the right order.
Thoughts?
Rusty.
next prev parent reply other threads:[~2012-07-13 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 22:59 virtio config access races Michael S. Tsirkin
2012-07-13 3:55 ` Rusty Russell [this message]
2012-07-13 3:55 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ukgz55o.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.