All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] socat: fix build failure due to ext2_fs.h header, bump version
Date: Thu, 17 May 2012 23:46:50 +0200	[thread overview]
Message-ID: <871umipjjp.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1337253358-5050-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 17 May 2012 13:15:57 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> In kernel >= 3.3, the ext2_fs.h can no longer be imported from
 Thomas> userspace. This has been fixed for internal toolchains by adding a
 Thomas> patch to kernel headers, but this doesn't work with toolchains
 Thomas> generated by Crosstool-NG, or potentially upcoming external
 Thomas> toolchains.

 Thomas> socat in fact has a test in its configure.in, but the configure was
 Thomas> generated too long ago, and the generated test relies on the
 Thomas> preprocessor result and not the compiler result (but warns that in the
 Thomas> future, the compiler result will be used instead of the preprocessor
 Thomas> result).

 Thomas> So, by running autoconf on this package, we fix the problem: it
 Thomas> properly checks whether ext2_fs is usable or not, and acts
 Thomas> accordingly. Of course, it means that with recent versions of the
 Thomas> kernel, ext2-specific features of socat are unavailable, and we'll
 Thomas> have to wait for the socat developers to adapt their code so that they
 Thomas> use the e2fsprogs headers.

 Thomas> We also bump the version, since a new minor version fixing a security
 Thomas> problem has been released.

Committed both, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2012-05-17 21:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 11:15 [Buildroot] [PATCH 1/2] socat: fix build failure due to ext2_fs.h header, bump version Thomas Petazzoni
2012-05-17 11:15 ` [Buildroot] [PATCH 2/2] socat: disable documentation build/installation Thomas Petazzoni
2012-05-17 13:34 ` [Buildroot] [PATCH 1/2] socat: fix build failure due to ext2_fs.h header, bump version Thomas Petazzoni
2012-05-17 21:46 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871umipjjp.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.