From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: manual merge of the akpm with the tree
Date: Thu, 17 May 2012 11:28:08 -0600 [thread overview]
Message-ID: <871umizphz.fsf@xmission.com> (raw)
In-Reply-To: <20120516164323.GA15140@redhat.com> (Oleg Nesterov's message of "Wed, 16 May 2012 18:43:24 +0200")
Oleg Nesterov <oleg@redhat.com> writes:
> On 05/16, Stephen Rothwell wrote:
>>
>> --- a/kernel/exit.c
>> +++ b/kernel/exit.c
>> @@@ -1218,7 -1218,7 +1218,7 @@@ static int wait_task_zombie(struct wait
>> unsigned long state;
>> int retval, status, traced;
>> pid_t pid = task_pid_vnr(p);
>> - uid_t uid = from_kuid_munged(current_user_ns(), __task_cred(p)->uid);
>> - uid_t uid = task_uid(p);
>> ++ uid_t uid = from_kuid_munged(current_user_ns(), task_uid(p));
>> struct siginfo __user *infop;
>
> Thanks Stephen, the fix looks correct.
>
> Oleg.
Yes. That looks good.
I'm not quite certain of my thinking there was. The two idioms are
equivalent. I suspect I confused task_uid(p) which is fine with
task_user_ns(p) which is only safe under the rtnl lock and should
probably be removed as a helper function because it isn't used that way.
Eric
prev parent reply other threads:[~2012-05-17 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 9:30 linux-next: manual merge of the akpm with the tree Stephen Rothwell
2012-05-16 16:43 ` Oleg Nesterov
2012-05-17 17:28 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871umizphz.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.