From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mmc@vger.kernel.org, svenkatr@ti.com
Subject: Re: [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes
Date: Wed, 18 Apr 2012 19:59:39 -0400 [thread overview]
Message-ID: <871unkmw0k.fsf@laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1204172230540.27488@axis700.grange> (Guennadi Liakhovetski's message of "Tue, 17 Apr 2012 22:31:17 +0200 (CEST)")
Hi,
On Tue, Apr 17 2012, Guennadi Liakhovetski wrote:
> On Tue, 17 Apr 2012, H Hartley Sweeten wrote:
>
>> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
>> for the two exported symbols.
>>
>> This quiets the sparse warnings:
>>
>> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
>> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Chris Ball <cjb@laptop.org>
>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> Acked-by: Venkatraman S <svenkatr@ti.com>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-04-18 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 20:03 [PATCH v2] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes H Hartley Sweeten
2012-04-17 20:03 ` H Hartley Sweeten
2012-04-17 20:31 ` Guennadi Liakhovetski
2012-04-18 23:59 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871unkmw0k.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.