From: Rusty Russell <rusty@rustcorp.com.au>
To: Mike Waychison <mikew@google.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH v1 1/2] virtio_net: Pass gfp flags when allocating rx buffers.
Date: Thu, 05 Jan 2012 10:40:02 +1030 [thread overview]
Message-ID: <871urfc8md.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120104225231.18184.96390.stgit@mike2.sea.corp.google.com>
On Wed, 04 Jan 2012 14:52:32 -0800, Mike Waychison <mikew@google.com> wrote:
> Currently, the refill path for RX buffers will always allocate the
> buffers as GFP_ATOMIC, even if we are in process context. This will
> fail to apply memory pressure as the worker thread will not contribute
> to the freeing of memory.
>
> Fix this by changing add_recvbuf_small to use the gfp variant allocator,
> __netdev_alloc_skb_ip_align().
>
> Signed-off-by: Mike Waychison <mikew@google.com>
OK, this is a no-brainer. Thanks! Dave, can you pick this up?
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers,
Rusty.
next prev parent reply other threads:[~2012-01-05 0:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 22:52 [RFC PATCH v1 0/2] virtio_net: Better low memory handling Mike Waychison
2012-01-04 22:52 ` [RFC PATCH v1 1/2] virtio_net: Pass gfp flags when allocating rx buffers Mike Waychison
2012-01-05 0:10 ` Rusty Russell [this message]
2012-01-05 18:21 ` David Miller
2012-01-05 18:21 ` David Miller
2012-01-04 22:52 ` Mike Waychison
2012-01-04 22:52 ` [RFC PATCH v1 2/2] virtio_net: Don't disable napi on low memory Mike Waychison
2012-01-05 0:31 ` Rusty Russell
2012-01-05 2:46 ` Mike Waychison
2012-01-05 2:46 ` Mike Waychison
2012-01-06 17:54 ` Mike Waychison
2012-01-06 17:54 ` Mike Waychison
2012-01-09 6:46 ` Rusty Russell
2012-01-09 6:46 ` Rusty Russell
2012-01-04 22:52 ` Mike Waychison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871urfc8md.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.