All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] i18n of multi-line messages
Date: Thu, 22 Dec 2011 18:07:57 +0100	[thread overview]
Message-ID: <871urwsff6.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <7vmxale9so.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 21 Dec 2011 16:20:55 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> I think the easiest way to tackle that sort of thing is to just do:
>>
>>     _("hint: %.*s\n")
>>
>> And have a TRANSLATORS comment indicating that the format string
>> should be kept, but that translators can move around the "hint", GNU
>> gettext also has a msgcheck feature to check that format strings are
>> compatible in the translations.
>
> Good point. Thanks.

Note that your commit message in pu still says

     - append each line in the result to localization of the "hint: " prefix.

even though you now fixed that to be more general.


(It also has a very weird case of mixed indentation when I view it with
'git show':

        advise(_("Please rename %s to something else"), gostak);
            advise(_("so that we can avoid distimming %s unnecessarily."), doshes);

Apparently the first line is indented with a tab, and the second with 8
spaces.)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2011-12-22 17:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 23:55 [RFC/PATCH] i18n of multi-line messages Junio C Hamano
2011-12-22  0:14 ` Ævar Arnfjörð Bjarmason
2011-12-22  0:20   ` Junio C Hamano
2011-12-22 17:07     ` Thomas Rast [this message]
2011-12-22  6:54 ` Johannes Sixt
2011-12-22  7:00   ` Junio C Hamano
2011-12-22  7:00   ` Junio C Hamano
2011-12-22  7:38   ` Junio C Hamano
2011-12-22  8:19     ` Johannes Sixt
2011-12-22 18:08       ` Junio C Hamano
2011-12-23  6:42         ` Johannes Sixt
2011-12-23 20:54           ` Junio C Hamano
2011-12-22 10:40     ` Chris Packham
2011-12-22 11:56       ` Andreas Schwab
2011-12-22 21:44     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871urwsff6.fsf@thomas.inf.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.