From: Kalle Valo <kvalo@adurom.com>
To: "Kahn\, Gery" <geryk@ti.com>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Subject: Re: [PATCH 2/2] wl12xx Export chip id to sysfs
Date: Mon, 18 Jul 2011 10:21:55 +0300 [thread overview]
Message-ID: <871uxouk8c.fsf@purkki.adurom.net> (raw)
In-Reply-To: <8762n0ukdu.fsf@purkki.adurom.net> (Kalle Valo's message of "Mon\, 18 Jul 2011 10\:18\:37 +0300")
Kalle Valo <kvalo@adurom.com> writes:
> Kalle Valo <kvalo@adurom.com> writes:
>
>>> After some investigation, found that ethtool's ioctl interface doesn't work
>>> at this case.
>>
>> This reminds me: I have patches for these issues but I never sent them
>> upstream. It's too late for me now, but I'll search them tomorrow (or
>> today to be exact..) and send them for testing purposes.
>
> Here's the patch I used:
And patch to ethtool:
diff --git a/ethtool.c b/ethtool.c
index 4226a67..6e80926 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -1363,12 +1363,15 @@ static int dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
fclose(f);
}
- if (!gregs_dump_hex)
+ if (!gregs_dump_hex) {
for (i = 0; i < ARRAY_SIZE(driver_list); i++)
if (!strncmp(driver_list[i].name, info->driver,
ETHTOOL_BUSINFO_LEN))
return driver_list[i].func(info, regs);
+ fprintf(stdout, "version: 0x%x\n", regs->version);
+ }
+
fprintf(stdout, "Offset\tValues\n");
fprintf(stdout, "--------\t-----");
for (i = 0; i < regs->len; i++) {
next prev parent reply other threads:[~2011-07-18 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 12:47 [PATCH 1/2] wl12xx: Fix for PG version and sysfs files Gery Kahn
2011-07-14 12:47 ` [PATCH 2/2] wl12xx Export chip id to sysfs Gery Kahn
2011-07-15 10:56 ` Kalle Valo
2011-07-17 8:16 ` Kahn, Gery
2011-07-17 12:51 ` Kahn, Gery
2011-07-17 21:45 ` Kalle Valo
2011-07-18 7:18 ` Kalle Valo
2011-07-18 7:21 ` Kalle Valo [this message]
2011-07-18 8:39 ` Kahn, Gery
2011-07-18 8:47 ` Kahn, Gery
2011-07-18 9:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uxouk8c.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=coelho@ti.com \
--cc=geryk@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.