All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-pm@lists.linux-foundation.org
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: pm_runtime_suspended() can be false if RPM_SUSPENDED
Date: Fri, 08 Jul 2011 16:41:00 -0700	[thread overview]
Message-ID: <871uy0733n.fsf@ti.com> (raw)

Hi Rafael,

Just curious why pm_runtime_suspended() requires the device to be
enabled for it to return true:

static inline bool pm_runtime_suspended(struct device *dev)
{
	return dev->power.runtime_status == RPM_SUSPENDED
		&& !dev->power.disable_depth;
}

I must be misunderstanding something, but I would consider a device that
has been runtime suspended before runtime PM was disabled to still be
runtime suspended.

I just noticed this when testing with your pm-domains branch.  when I
noticed that an 'if (pm_runtime_suspended(dev))' check in my PM domain's
->suspend_noirq() was always failing since it's after the PM core calls
pm_runtime_disable().  I had to change my PM domain code to only check
dev->power.runtime_status for it to work.

Kevin

             reply	other threads:[~2011-07-08 23:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08 23:41 Kevin Hilman [this message]
2011-07-09 10:19 ` pm_runtime_suspended() can be false if RPM_SUSPENDED Rafael J. Wysocki
2011-07-11 19:24   ` Kevin Hilman
2011-07-11 20:02     ` Rafael J. Wysocki
2011-07-11 20:02     ` Rafael J. Wysocki
2011-07-11 20:14       ` Kevin Hilman
2011-07-11 20:22         ` Rafael J. Wysocki
2011-07-11 20:22         ` Rafael J. Wysocki
2011-07-11 20:34           ` Hilman, Kevin
2011-07-11 20:34           ` Hilman, Kevin
2011-07-11 22:36             ` Rafael J. Wysocki
2011-07-11 22:36             ` Rafael J. Wysocki
2011-07-11 22:50               ` Hilman, Kevin
2011-07-11 22:50               ` Hilman, Kevin
2011-07-11 20:14       ` Kevin Hilman
2011-07-11 19:24   ` Kevin Hilman
2011-07-09 10:19 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2011-07-08 23:41 Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871uy0733n.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.