diff for duplicates of <871uzahnib.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index 6beca04..5508658 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ Tomi Valkeinen <tomi.valkeinen@ti.com> writes: It's not clear to me what the lock is trying to protect. I guess it's the counter? I don't think it should be needed... -> + if (dispc.runtime_count++ = 0) { +> + if (dispc.runtime_count++ == 0) { You shouldn't need your own use-counting here. The runtime PM core is already doing usage counting. @@ -69,7 +69,7 @@ transitions from zero. > +{ > + mutex_lock(&dispc.runtime_lock); > + -> + if (--dispc.runtime_count = 0) { +> + if (--dispc.runtime_count == 0) { > + int r; Same problem here. @@ -111,8 +111,8 @@ the "normal" (async) version.: pm_runtime_put(). Based on the above suggestions, you probably don't need dedicated functions for this. Just call pm_runtime_get_sync() here... -> if (channel = OMAP_DSS_CHANNEL_LCD || -> channel = OMAP_DSS_CHANNEL_LCD2) +> if (channel == OMAP_DSS_CHANNEL_LCD || +> channel == OMAP_DSS_CHANNEL_LCD2) > @@ -571,7 +686,7 @@ void dispc_go(enum omap_channel channel) > else > REG_FLD_MOD(DISPC_CONTROL, 1, bit, bit); diff --git a/a/content_digest b/N1/content_digest index cc4509f..ad88518 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01307095237-14805-20-git-send-email-tomi.valkeinen@ti.com\0" "From\0Kevin Hilman <khilman@ti.com>\0" "Subject\0Re: [PATCH 19/27] OMAP: DSS2: Use PM runtime & HWMOD support\0" - "Date\0Fri, 03 Jun 2011 16:45:48 +0000\0" + "Date\0Fri, 03 Jun 2011 09:45:48 -0700\0" "To\0Tomi Valkeinen <tomi.valkeinen@ti.com>\0" "Cc\0linux-omap@vger.kernel.org" linux-fbdev@vger.kernel.org @@ -32,7 +32,7 @@ "It's not clear to me what the lock is trying to protect. I guess it's\n" "the counter? I don't think it should be needed...\n" "\n" - "> +\tif (dispc.runtime_count++ = 0) {\n" + "> +\tif (dispc.runtime_count++ == 0) {\n" "\n" "You shouldn't need your own use-counting here. The runtime PM core is\n" "already doing usage counting.\n" @@ -81,7 +81,7 @@ "> +{\n" "> +\tmutex_lock(&dispc.runtime_lock);\n" "> +\n" - "> +\tif (--dispc.runtime_count = 0) {\n" + "> +\tif (--dispc.runtime_count == 0) {\n" "> +\t\tint r;\n" "\n" "Same problem here. \n" @@ -123,8 +123,8 @@ "Based on the above suggestions, you probably don't need dedicated\n" "functions for this. Just call pm_runtime_get_sync() here...\n" "\n" - "> \tif (channel = OMAP_DSS_CHANNEL_LCD ||\n" - "> \t\t\tchannel = OMAP_DSS_CHANNEL_LCD2)\n" + "> \tif (channel == OMAP_DSS_CHANNEL_LCD ||\n" + "> \t\t\tchannel == OMAP_DSS_CHANNEL_LCD2)\n" "> @@ -571,7 +686,7 @@ void dispc_go(enum omap_channel channel)\n" "> \telse\n" "> \t\tREG_FLD_MOD(DISPC_CONTROL, 1, bit, bit);\n" @@ -137,4 +137,4 @@ "\n" Kevin -87eb2a28385026f92f27c2313f48ea359a9c55fbb87879c56be57b71565e267b +443feb6e77c99969c71790132ca61abb8f50a3f35aa1def85ef1e9598af5cfa0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.