All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Philipp Wiesner <p.wiesner@phytec.de>
Subject: Re: [PATCH v2 10/11] mt9m111: rewrite set_pixfmt
Date: Sun, 29 Aug 2010 21:17:00 +0200	[thread overview]
Message-ID: <871v9hmdoz.fsf@free.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.1008271335200.28043@axis700.grange> (Guennadi Liakhovetski's message of "Fri\, 27 Aug 2010 13\:42\:24 +0200 \(CEST\)")

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> Robert, I'll need your ack / tested by on this one too. It actually 
> changes behaviour, for example, it sets MT9M111_OUTFMT_FLIP_BAYER_ROW in 
> the OUTPUT_FORMAT_CTRL register for the V4L2_MBUS_FMT_SBGGR8_1X8 8 bit 
> Bayer format. Maybe other things too - please have a look.

For the YUV and RGB formats, tested and acked.
For the bayer, I don't use it. With row switch, that gives back:
byte offset: 0 1 2 3
             B G B G
             G R G R

Without the switch:
byte offset: 0 1 2 3
             G R G R
             B G B G

I would have expected the second version (ie. without the switch, ie. the
original version of mt9m111 driver) to be correct, but I might be wrong. Maybe
Michael can enlighten me here.

-- 
Robert

  reply	other threads:[~2010-08-29 19:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 10:57 [PATCH v2 00/11] MT9M111/MT9M131 Michael Grzeschik
2010-08-03 10:57 ` [PATCH v2 01/11] mt9m111: Added indication that MT9M131 is supported by this driver Michael Grzeschik
2010-08-03 10:57 ` [PATCH 02/11] mt9m111: init chip after read CHIP_VERSION Michael Grzeschik
2010-08-03 10:57 ` [PATCH 03/11] mt9m111: register cleanup hex to dec bitoffset Michael Grzeschik
2010-08-03 10:57 ` [PATCH 04/11] mt9m111: added new bit offset defines Michael Grzeschik
2010-08-27 15:11   ` Guennadi Liakhovetski
2010-08-27 15:35     ` Michael Grzeschik
2010-08-27 16:30       ` Guennadi Liakhovetski
2010-08-27 17:09         ` Michael Grzeschik
2010-08-03 10:57 ` [PATCH 05/11] mt9m111: changed MIN_DARK_COLS to MT9M131 spec count Michael Grzeschik
2010-08-03 10:57 ` [PATCH 06/11] mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE Michael Grzeschik
2010-08-03 10:57 ` [PATCH 07/11] mt9m111: added current colorspace at g_fmt Michael Grzeschik
2010-08-03 10:57 ` [PATCH 08/11] mt9m111: added reg_mask function Michael Grzeschik
2010-08-03 10:57 ` [PATCH 09/11] v4l2-mediabus: Add pixelcodes for BGR565 formats Michael Grzeschik
2010-08-03 10:57 ` [PATCH v2 10/11] mt9m111: rewrite set_pixfmt Michael Grzeschik
2010-08-27 11:42   ` Guennadi Liakhovetski
2010-08-29 19:17     ` Robert Jarzmik [this message]
2010-08-31  7:46       ` Michael Grzeschik
2010-09-04 20:35         ` Guennadi Liakhovetski
2010-10-02  8:03           ` Guennadi Liakhovetski
2010-10-25  9:42             ` Michael Grzeschik
2010-10-25 10:11   ` [PATCH v3] " Michael Grzeschik
2010-10-25 20:19     ` Guennadi Liakhovetski
2010-08-03 10:57 ` [PATCH v2 11/11] mt9m111: make use of testpattern Michael Grzeschik
2010-08-29 16:57   ` Robert Jarzmik
2010-08-29 18:35     ` Guennadi Liakhovetski
2010-09-05 16:44       ` Robert Jarzmik
2010-08-17 13:17 ` [PATCH v2 00/11] MT9M111/MT9M131 Michael Grzeschik
2010-08-17 13:21   ` Guennadi Liakhovetski
2010-08-29 19:20     ` Robert Jarzmik
2010-08-31  8:04       ` Michael Grzeschik
2010-08-18 18:05   ` Robert Jarzmik
2010-08-22 18:07     ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871v9hmdoz.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-media@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=p.wiesner@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.