All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] Implement basic non-wget download methods
Date: Sun, 18 Jul 2010 23:22:46 +0200	[thread overview]
Message-ID: <871vb0wkm1.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20100716103902.GF16232@bulix.org> (Maxime Petazzoni's message of "Fri, 16 Jul 2010 12:39:02 +0200")

>>>>> "Maxime" == Maxime Petazzoni <maxime.petazzoni@bulix.org> writes:

Hi,

 >> In a broader sense what are these configuration options for?  Is it to
 >> allow adding switches (e.g. git checkout -f) to the commands or is it to
 >> allow specifying the path to the executable
 >> (e.g. /usr/bin/svn, /opt/git4.0-pre/bin/git)?
 >> If it's the first case, I'd side with GIT_CLONE and GIT_CO.  If it's the
 >> second case, I'd leave it as GIT but get rid of the GIT_CO and just put
 >> the actual command in Makefile.package.in.  Is is likely that they will
 >> ever differ from "clone" or "checkout" anyway?

 Maxime> I don't really know what they are for. Maybe some "older" Buildroot
 Maxime> developers could give us some details there. Because you're right, git
 Maxime> clone will most likely remain git clone. But having the option to use a
 Maxime> specific path is usefull, in which case I'd leave only GIT="git". But
 Maxime> then the same would apply to SVN_CO/SVN_UP where we should only keep
 Maxime> SVN="svn".

Yes, they are really old and not used (besides SVN_CO) - Feel free to
clean this up while making these changes.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-07-18 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13  9:51 [Buildroot] [PATCH 2/4] Implement basic non-wget download methods Luca Ceresoli
2010-07-13 11:30 ` Maxime Petazzoni
2010-07-14 12:02   ` Quotient Remainder
2010-07-16 10:39     ` Maxime Petazzoni
2010-07-18 21:22       ` Peter Korsgaard [this message]
2010-07-20  5:48         ` Maxime Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2010-07-13  7:15 [Buildroot] [PATCH/RFC] Git/Svn downloaders Maxime Petazzoni
2010-07-13  7:15 ` [Buildroot] [PATCH 2/4] Implement basic non-wget download methods Maxime Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vb0wkm1.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.