From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] pxa_camera: Redesign DMA handling
Date: Sun, 08 Mar 2009 01:39:42 +0100 [thread overview]
Message-ID: <871vt8hmpd.fsf@free.fr> (raw)
In-Reply-To: Pine.LNX.4.64.0903080003010.6783@axis700.grange
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> Emn, no. Just looked in CodingStyle - haven't found a word about it. So, I
> think, applies "keep consistent with the rest of the file." And, you know,
> someone might call this a matter of taste, but a line like
>
> x = y
>
> in a .c file looks unfinished to me, whereas
>
> x = y +
>
> clearly has a continuation. That's how I learned to break lines at school,
> at the Uni,... Ok, never mind, in any case, until this is not in
> CodingStyle, I will nak all attempts to convert the whole driver to the
> opposite of what it has ATM. So, I'll drop "3/4" and will request
> amendments to other affected patches, ok?
OK, no problem.
I'm neither strongly fond of one syntax or the other. I'll amend the other
patches while you're working on the review.
Cheers.
--
Robert
next prev parent reply other threads:[~2009-03-08 0:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 19:17 [PATCH] pxa_camera: Redesign DMA handling Robert Jarzmik
2009-03-03 7:26 ` Mike Rapoport
2009-03-03 15:49 ` Guennadi Liakhovetski
2009-03-03 18:47 ` Robert Jarzmik
2009-03-07 23:11 ` Guennadi Liakhovetski
2009-03-08 0:39 ` Robert Jarzmik [this message]
2009-03-04 18:11 ` Robert Jarzmik
2009-03-11 12:22 ` Guennadi Liakhovetski
[not found] <722242271.3317321236779109198.JavaMail.root@zimbra20-e3.priv.proxad.net>
2009-03-11 13:48 ` robert.jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vt8hmpd.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.