From: Andi Kleen <andi@firstfloor.org>
To: David John <davidjon@xenontk.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
clemens@ladisch.de, venkatesh.pallipadi@intel.com,
vojtech@suse.cz, bob.picco@hp.com
Subject: Re: [PATCH] HPET: Remove the BKL.
Date: Thu, 09 Oct 2008 14:59:21 +0200 [thread overview]
Message-ID: <871vypudp2.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1223551371-3764-1-git-send-email-davidjon@xenontk.org> (David John's message of "Thu, 9 Oct 2008 16:52:51 +0530")
David John <davidjon@xenontk.org> writes:
> @@ -586,7 +583,7 @@ static const struct file_operations hpet_fops = {
> .llseek = no_llseek,
> .read = hpet_read,
> .poll = hpet_poll,
> - .ioctl = hpet_ioctl,
> + .unlocked_ioctl = hpet_ioctl,
Did this actually compile without warning? unlocked_ioctl
has a different prototype than ioctl
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-10-09 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 11:22 [PATCH] HPET: Remove the BKL David John
2008-10-09 12:59 ` Andi Kleen [this message]
2008-10-09 14:30 ` David John
-- strict thread matches above, loose matches on Subject: below --
2008-10-10 8:00 David John
2008-10-09 8:55 David John
2008-10-09 10:31 ` Andi Kleen
2008-10-09 11:08 ` David John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vypudp2.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=bob.picco@hp.com \
--cc=clemens@ladisch.de \
--cc=davidjon@xenontk.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=venkatesh.pallipadi@intel.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.